Allow image preview in modal - not working for file lists within modals

Bug #1631809 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

The patch for bug 1572356 only dealt with the files list on the Content -> files page.

But what would be more useful is if the picker worked within other modal popups, like when picking an image to an image block or picking an image within the tinymce image picker.

So I've added a patch to deal with this and also fixed the issue where profileicon images could not be chosen.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7105

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 16.10.0
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7105
Committed: https://git.mahara.org/mahara/mahara/commit/6601edd07bcd347a4e4c640cb07d73a775dde11e
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 6601edd07bcd347a4e4c640cb07d73a775dde11e
Author: Robert Lyon <email address hidden>
Date: Mon Oct 10 10:57:18 2016 +1300

Bug 1631809: Allow image preview modal use within other modals

Like adding image block modal or tinymce insert image modal

behatnotneeded

Change-Id: If608f87b852b8ee2e4d6c74bdf2a31124599eb03
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7159

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7159
Committed: https://git.mahara.org/mahara/mahara/commit/2933ccf89514b3ea163caa3f1b52817943fda8d5
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 2933ccf89514b3ea163caa3f1b52817943fda8d5
Author: Robert Lyon <email address hidden>
Date: Mon Oct 10 10:57:18 2016 +1300

Bug 1631809: Allow image preview modal use within other modals

Like adding image block modal or tinymce insert image modal

behatnotneeded

Change-Id: If608f87b852b8ee2e4d6c74bdf2a31124599eb03
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6601edd07bcd347a4e4c640cb07d73a775dde11e)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: nominatedfeature
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.