Mahara

Annotation feedback changes

Bug #1632865 reported by Kristina Hoeppner on 2016-10-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Fix Released	Medium	Robert Lyon	Mahara 16.10.0

Bug Description

Mahara 16.10dev

When feedback is placed on an annotation block, it is called "Annotation", but it should be feedback.

In order to make it look more like the "Comments" on an artefact, it should be changed like in the screenshot to include the "Comments" icon and then "Feedback" with the count at the end.

The icon before "Place feedback" should be the one we use for "Add comment", but no text change.

Revision history for this message

Kristina Hoeppner (kris-hoeppner) wrote on 2016-10-12:

smartevidence_annotation_feedback.png Edit (14.8 KiB, image/png)

Revision history for this message

Kristina Hoeppner (kris-hoeppner) wrote on 2016-10-12:

There is bug #1632868 for displaying the feedback in a modal.

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-10-12: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7117

Robert Lyon (robertl-9) on 2016-10-12

Changed in mahara:
status:	Confirmed → In Progress

Revision history for this message

Niranjan (niranjan528) wrote on 2016-10-13:

Tested it on FF browser and here are my findings:

Feedback and place feedback buttons are now shown on the page, but when we give few feedbacks the number of feedbacks are wrong and also when a feedback is deleted it is still showing up and doesn't get deleted .

Revision history for this message

Niranjan (niranjan528) wrote on 2016-10-14:

Tested back and I found that the pagination is not correct for newly added feedback.

For every feedback added it is taken as 2 feedbacks and it shows wrong number for the feedback.

Please look into it,

Cheers,
Niranjan

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-10-20: A change has been merged

Reviewed: https://reviews.mahara.org/7117
Committed: https://git.mahara.org/mahara/mahara/commit/8ceb68d384ee771f7499a78cfcd3c982a63c6eed
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 8ceb68d384ee771f7499a78cfcd3c982a63c6eed
Author: Robert Lyon <email address hidden>
Date: Thu Oct 13 11:30:34 2016 +1300

Bug 1632865: Changing how we display annotation feedback

Changing it to how we show artefact feedback

behatnotneeded

Change-Id: I31090e7dd3c616687f7b00cd281e523e993e0479
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-10-20: A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7187

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-10-20: A change has been merged

Reviewed: https://reviews.mahara.org/7187
Committed: https://git.mahara.org/mahara/mahara/commit/d14e98c202c26abe67185f8a447d9365809134da
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit d14e98c202c26abe67185f8a447d9365809134da
Author: Robert Lyon <email address hidden>
Date: Thu Oct 13 11:30:34 2016 +1300

Bug 1632865: Changing how we display annotation feedback

Changing it to how we show artefact feedback

behatnotneeded

Change-Id: I31090e7dd3c616687f7b00cd281e523e993e0479
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 8ceb68d384ee771f7499a78cfcd3c982a63c6eed)

Robert Lyon (robertl-9) on 2016-10-20