Barbarian campaing, scenario 2: yellow brother bails out

AI has a policy to dismantle a site if not connected to warehouse for some time. Soldiers can find a way home and productionsites are useless if not connected to warehouse.
But I can imagine an exemption here - do not dismantle unconnected buildings if a player has no warehouse at all, makes sense.

Assigning it to me, I hope I will not forget about it...

Alternatively it would be helpful to turn the AI completely off for defined players in some scenario design. Even better to change the state of the AI for every Computer player between "off" "poor" and "good" via script. Had an issue with the Ai dismantling the wrong building in empire 4 lately.

We could try changing the AI in the player_names packet

https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/data/campaigns/bar02.wmf/player_names

Legal value is probably "empty", try "none" if that doesn't work.

Switching between various AI types can be problematic, as weaker AIs have some buildings limited, so I am not sure how AI would cope with such changing limit....

I have tried to use ai="none" and run a test game, this seems to work, all buildings of the yellow player were still there as i reached him. The buildings weren't connected with roads, though. That could be fixed and is the reason for the merge request: https://code.launchpad.net/~widelands-dev/widelands/fix_infrastructure_return_values/+merge/337364

But there is another issue:
If i start the game and make the area of the yellow player visible, i see that from time to time a soldier get out of a military building, walking directionless around. You could try that yourself:

1. Run the game and open the second barbarian campaign
2. Wait until the first message box is shown and close it
3. Pause the game
4. Open the scripting console
5. Reveal the area of the yellow player and scroll to it (do not reveal all fields, because that will raise additional tasks):
    p1:reveal_fields(map.Game().map:get_field(135,85):region(12))
    scroll_to_field(wl.Game.map:get_field(135,85))
6. Set game speed to 3x or more

After some time a soldier leaves a military building.

Used ai="empty" now and manually connected the military buildings with some roads. tested by revealing the fields like described in #5 and let the game run for about 3hrs gametime without interaction. No soldiers left the buildings and the buildings get not destroyed.

Not tested how the empty ai manage defense of the buildings. Would this be affected if ai="empty" is set?

The linked branch contains these changes, but need this branch as prerequisite:

https://code.launchpad.net/~widelands-dev/widelands/fix_infrastructure_return_values/+merge/337364

Will test the defense question later...

Ai won't manage the defense of the buildings, since there is no AI. Soldiers will simply stay put and defend each building when attacked.

Fixed in build20-rc1