No longer works in Yakkety

Bug #1639607 reported by Carlos Maddela
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
usb-modeswitch (Debian)
Fix Released
Unknown
usb-modeswitch (Ubuntu)
Fix Released
High
Gunnar Hjalmarsson
Yakkety
Fix Released
High
Gunnar Hjalmarsson

Bug Description

[Impact]

Since /lib/udev/usb_modeswitch relies on /lib/udev/hotplug.functions which has been removed from systemd, usb-modeswitch fails in Yakkety.

[Test Case]

Well, it's easiest to test with a USB dongle. My own (gunnarhj) Huawei E1750 fails to trigger mobile broadband on Ubuntu 16.10 with usb-modeswitch 2.2.5+repack0-1ubuntu1. After having built the package with the attached debdiff it works as expected.

[Regression Potential]

Low. The proposal mirrors an upstream commit:

https://anonscm.debian.org/cgit/collab-maint/usb-modeswitch.git/commit/?id=10a6240885e98b55f512b0a85fb8d44cbaca503e

The related Debian bug report is at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=810104 and has been fixed in version 2.3.0+repack0-1.

Related branches

Carlos Maddela (e7appew)
description: updated
no longer affects: language-selector (Ubuntu Yakkety)
no longer affects: language-selector (Ubuntu)
Changed in usb-modeswitch (Ubuntu):
assignee: nobody → Gunnar Hjalmarsson (gunnarhj)
importance: Undecided → High
status: New → In Progress
Changed in usb-modeswitch (Ubuntu Yakkety):
assignee: nobody → Gunnar Hjalmarsson (gunnarhj)
importance: Undecided → High
status: New → In Progress
tags: added: patch
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Thanks for reporting this and spotting the applicable commit! Since wily is EOL, your proposal isn't so visible, so I converted it into two debdiffs (for zesty and yakkety) and subscribed ubuntu-sponsors.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :
Changed in usb-modeswitch (Debian):
status: Unknown → Fix Released
Revision history for this message
zak wylde (balloonbending) wrote :

 Sorry to ask but how do i apply this patch? If this is the issue where the mobile broadband dongle no longer shows up in the list of available connections, I have this issue since upgrading to 16.10 from 16.04 as well). thx.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

@zak wylde: If you can't wait, you can install from Debian; please see <http://askubuntu.com/a/851296>.

description: updated
description: updated
Revision history for this message
zak wylde (balloonbending) wrote :

@Gunnar - thanks, that seemed to work. At least I can get online now :)

Jeremy Bícha (jbicha)
Changed in usb-modeswitch (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Uploaded to yakkety's unapproved queue. A member of the Stable Release team will need to manually approve it before it can be published as a proposed update for Ubuntu 16.10.

I'm unsubscribing ~ubuntu-sponsors now. Feel free to resubscribe if there's something else that needs to be sponsored.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package usb-modeswitch - 2.4.0+repack0-1ubuntu1

---------------
usb-modeswitch (2.4.0+repack0-1ubuntu1) zesty; urgency=medium

  * Sync with Debian (LP: #1639607, #1639379). Remaining changes:
    - Replace libjim/jimsh build-depends with libpipeline-dev, libudev-dev.
    - dispatcher-c-rewrite.patch: Rewrite dispatcher in C to avoid TCL deps.
    - redirect_dispatcher_output.patch: redirect all dispatcher output when
      called from udev to /dev/null.
    - systemd_service_name.patch: fix instance name for systemd;
      make sure we don't try to start usb-modeswitch with an invalid instance
      name.
  * Refresh patches

usb-modeswitch (2.4.0+repack0-1) unstable; urgency=medium

  * New 2.4.0 upstream release
  * Refresh patches
  * Bump S-V to 3.9.8 without changes needed
  * Set hardening=+all in DEB_BUILD_MAINT_OPTIONS
  * Use the https alternative in VCS-Browser
  * Add patch to fix official{,l}y typo

usb-modeswitch (2.3.0+repack0-1) unstable; urgency=medium

  * New 2.3.0 upstream release
    - Fixed bug which prevented early logging
  * Remove patch to use udev-specific code to wait on /usr mount
    (Closes: #810104)
  * Update gbp.conf

usb-modeswitch (2.2.6+repack0-1) unstable; urgency=medium

  * New 2.2.6 upstream release

usb-modeswitch (2.2.5+repack0-1) unstable; urgency=medium

  * New 2.2.5 upstream release
  * Refresh patches

 -- Jeremy Bicha <email address hidden> Sun, 11 Dec 2016 22:39:28 -0500

Changed in usb-modeswitch (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

Reading this changelog as an SRU team member I find it really unhelpful if not confusing.

+ * Cherry-pick commit 10a62408 from Debian unstable to resolve
+ incompatibility with systemd (>= 230-1~) (LP: #1639607).

Using the words "cherry-pick" and then dropping a patch:

+++ usb-modeswitch-2.2.5+repack0/debian/patches/series 2016-11-06 18:19:05.000000000 +0000
@@ -1,4 +1,3 @@
-03_use_udev_specifics.patch

is what I find confusing. I think using the upstream changelog entry and or commit comment would have been more informative in this case.

Changed in usb-modeswitch (Ubuntu Yakkety):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Carlos, or anyone else affected,

Accepted usb-modeswitch into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/usb-modeswitch/2.2.5+repack0-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

I installed usb-modeswitch 2.2.5+repack0-1ubuntu1.1 from yakkety-proposed and confirmed the test case.

@Brian: Not sure I understand your remark on the changelog entry. Dropping that patch was part of the upstream commit.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Gunnar, I think he's recommending that an SRU changelog be more specific about what's being done to the package.

As an example, Ubuntu security fix changelogs tend to be extremely specific [1], listing not only the patch name but even the specific source file changed and what the change was. I don't think regular SRUs need to be as specific as that, but I think Brian wanted us to mention in the changelog that we did drop a patch.

[1] https://launchpad.net/ubuntu/+source/game-music-emu/0.6.0-3ubuntu0.16.04.1

Revision history for this message
Thomas Norheim (thomas-norheim) wrote :

I enabled proposed on Yakkety and updated, and now works for me with usb-modeswitch 2.2.5+repack0-1ubuntu1.1.

Revision history for this message
Brian Murray (brian-murray) wrote :

Yes, something like "Cherry pick .. from Debian unstable" which drops patch 1234 because it was incorrect would have been more informative. Generally speaking seeing patches removed in an SRU is quite suspicious.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package usb-modeswitch - 2.2.5+repack0-1ubuntu1.1

---------------
usb-modeswitch (2.2.5+repack0-1ubuntu1.1) yakkety; urgency=medium

  * Cherry-pick commit 10a62408 from Debian unstable to resolve
    incompatibility with systemd (>= 230-1~) (LP: #1639607).

 -- Carlos Maddela <email address hidden> Mon, 07 Nov 2016 05:19:05 +1100

Changed in usb-modeswitch (Ubuntu Yakkety):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for usb-modeswitch has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.