subtitle downloads hang

It looks like there's a fixed extension available:
https://addons.videolan.org/p/1154045/

Status changed to 'Confirmed' because the bug affects multiple users.

Yes, the fixed extension indeed fixed it! Thanks for the link

When I was using the old VLsubs extension and tried to find a sub by hash, my VLC player crashed, so it is quite annoying bug.

The upstream fix: http://git.videolan.org/?p=vlc/vlc-2.2.git;a=commit;h=4b1c65d5da017d807efea415fb3ab069945da75d

I'd like to propose a fix for this in yakkety, vlc=2.2.4-4ubuntu0.16.10.1.

Sure. It needs to be fixed in zesty first though. Maybe you can get sramacher to release quicker? :) (or, tbf, I could do a Team Upload being in the debian-multimedia team, but I'd rather not, I've never touched vlc)

As you can see he'll upload it "soon" :)

On Fri, Dec 09, 2016 at 05:57:03PM -0000, Andrew Shadura wrote:
> As you can see he'll upload it "soon" :)

please poke once he does (even on IRC if you feel so).

--
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-

Version 2.2.4-11 in zesty fixes this.

uploaded the SRU, now in the unapproved queue.

Thanks for uploading the fix for this bug report to -proposed. However, when reviewing the package in -proposed and the details of this bug report I noticed that the bug description is missing information required for the SRU process. You can find full details at http://wiki.ubuntu.com/StableReleaseUpdates#Procedure but essentially this bug is missing some of the following: a statement of impact, a test case and details regarding the regression potential. Thanks in advance!

I'll try to do that paperwork:
[Impact]
The subtitle downloading process is hanging, there is an error message. Every user trying to download a subtitle for a movie will get the error.
[Test Case]
1. start vlc
2. click on View->Download Subtitles
3. select 'subtitles language' English
4. fill 'title' with Avatar
5. click on 'search by name'

You'll get the window titled 'Extension not responding'.
6. After a long waiting time, click on the first search result and click the 'download selection' link
Nothing happens
[Regression Potential]
Low. The subtitle downloader wasn't working, worst thing that would happen would be the patched subtitle downloader to cause a crash when used.

There is an easy available workaround available.
edit /lib/vlc/lua/extensions/VLSub.luac and replace all occurrences of "HTTP/1.1" with "HTTP/1.0" (even if it is a binary file). At least it worked for me:

sudo vi /usr/lib/vlc/lua/extensions/VLSub.luac
:%s#HTTP/1.1#HTTP/1.0#g
:wq

The upload for Yakkety seems to have a malformed bug reference. This affects bug tracking for the SRU.

umpf, the missing '#' ?
ahem, do you want to reject and we reupload with the additional # ?

I have rejected the vlc from the yakkety queue and re-uploaded with a fixed changelog. This should be good to go into yakkety-proposed. Thanks for the packaging the fix!

Hello Götz, or anyone else affected,

Accepted vlc into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/vlc/2.2.4-4ubuntu0.16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hi Łukasz, there's only an update for yakkety, but I don't run it, I'm on xenial, so I cannot test this.

I have tested this and it works as expected.

This bug was fixed in the package vlc - 2.2.4-4ubuntu0.16.10.1

---------------
vlc (2.2.4-4ubuntu0.16.10.1) yakkety; urgency=medium

  [ Sebastian Ramacher ]
  * debian/patches/VLSub-don-t-pretend-to-support-HTTP-1.1.patch: Apply
    upstream to fix VLSub incorrectly announcing HTTP 1.1 support.
    (Closes: #847559; LP: #1639750)

 -- Andrew Shadura <email address hidden> Fri, 09 Dec 2016 18:01:48 +0100

The verification of the Stable Release Update for vlc has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

It looks like this still needs fixing in Xenial, so I modified the debdiff for 16.04 and uploaded it to the queue for review by the SRU team.

Hello Götz, or anyone else affected,

Accepted vlc into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/vlc/2.2.2-5ubuntu0.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Dear Łukasz, I have successfully tested the proposed update on xenial, thanks.

Thank you for your tests, Götz!

This bug was fixed in the package vlc - 2.2.2-5ubuntu0.16.04.1

---------------
vlc (2.2.2-5ubuntu0.16.04.1) xenial; urgency=medium

  [ Sebastian Ramacher ]
  * debian/patches: Apply upstream to fix VLSub incorrectly announcing HTTP
    1.1 support. (LP: #1639750)

 -- Brian Murray <email address hidden> Tue, 21 Feb 2017 15:23:51 -0800