Mahara

New View() fails if called with deleted parameter set

Bug #1650954 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 17.04.0
16.10
Fix Released
Medium
Unassigned
Mahara 16.10.3
17.04
Fix Released
Medium
Unassigned
Mahara 17.04.0

Bug Description

The doublecheck we added within View constructor for view_rows_columns to make sure the rows exist fails to take into account calling new View() with 'deleted' parameter set to true.

This is used in Leap2A import to make a 'dummy' view to allow the adding of a new view layout type.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7340

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7340
Committed: https://git.mahara.org/mahara/mahara/commit/0e470890bf6be4791edf5e1267812dc0f53822dd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0e470890bf6be4791edf5e1267812dc0f53822dd
Author: Robert Lyon <email address hidden>
Date: Mon Dec 19 09:09:47 2016 +1300

Bug 1650954: View Constructor to ignore trying to make view_rows_columns

When it is set to be deleted straight away via parameter 'deleted' = true

behatnotneeded

Change-Id: I26204b8d358520c6acf3434531c06c4490152f47
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7388

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7388
Committed: https://git.mahara.org/mahara/mahara/commit/ba885abca500632720ecd4f6f8a370fb6e61e6ac
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit ba885abca500632720ecd4f6f8a370fb6e61e6ac
Author: Robert Lyon <email address hidden>
Date: Mon Dec 19 09:09:47 2016 +1300

Bug 1650954: View Constructor to ignore trying to make view_rows_columns

When it is set to be deleted straight away via parameter 'deleted' = true

behatnotneeded

Change-Id: I26204b8d358520c6acf3434531c06c4490152f47
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 0e470890bf6be4791edf5e1267812dc0f53822dd)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.