Mahara

Undefined variable: type in Content screen. Prod mode=true

Bug #1651018 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic
Mahara 17.04.0
16.10
Fix Released
High
Unassigned
Mahara 16.10.2
17.04
Fix Released
High
Cecilia Vela Gurovic
Mahara 17.04.0

Bug Description

if we have these values in config.php

$cfg->productionmode = true;
$cfg->nocache=false;
$cfg->log_warn_targets = LOG_TARGET_SCREEN | LOG_TARGET_ERRORLOG;

Following error shows up in Content screen:

[WAR] 32 (artefact/file/lib.php:2516) Undefined variable: type
Call stack (most recent first):

    log_message(string(size 24), integer, true, true, string(size 87), integer) at /var/www/mahara-org-testing-mahara/releases/20161215230023/htdocs/lib/errors.php:521
    error(integer, string(size 24), string(size 87), integer, array(size 8)) at /var/www/mahara-org-testing-mahara/releases/20161215230023/htdocs/artefact/file/lib.php:2516
    ArtefactTypeProfileIcon::download_thumbnail(integer) at /var/www/mahara-org-testing-mahara/releases/20161215230023/htdocs/thumb.php:32

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7344

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

We haven't seen this error before because the code with the error only executes when nocache=false, and when productionmode=false (to see error messages) the system sets nocache=true and the code is never reached.

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
milestone: none → 17.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7344
Committed: https://git.mahara.org/mahara/mahara/commit/c779256cea0d521b8cd9a8401e8ab64ac2e94417
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c779256cea0d521b8cd9a8401e8ab64ac2e94417
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Dec 19 16:26:04 2016 +1300

Bug 1651018: fixed hidden error in Content screen, undefined $type

behatnotneeded

Change-Id: I1a61e47154cef6fdcb62276aa3ba212037121064

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7349

Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → High
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7349
Committed: https://git.mahara.org/mahara/mahara/commit/a157de312c643999ee9bbb85af5dfcfa0e9326d9
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit a157de312c643999ee9bbb85af5dfcfa0e9326d9
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Dec 19 16:26:04 2016 +1300

Bug 1651018: fixed hidden error in Content screen, undefined $type

behatnotneeded

Change-Id: I1a61e47154cef6fdcb62276aa3ba212037121064
(cherry picked from commit c779256cea0d521b8cd9a8401e8ab64ac2e94417)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.