Ubuntu
ubuntu-fan package

fanatic enable/disable docker broken with docker.io >= 1.12

Bug #1656875 reported by Stefan Bader
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-fan (Ubuntu)
Fix Released
Medium
Stefan Bader
Xenial
Fix Released
Medium
Unassigned
Yakkety
Fix Released
Medium
Unassigned

Bug Description

The way docker handles networks changed when moving to newer docker versions. Networks are now created/deleted by "docker network" commands (similar to LXD). This needs to be handled by fanatic when doing docker related tasks.

SRU Justification:

Impact: fanatic was written when an older version of docker.io was in the archive for Yakkety and Xenial. However docker.io does SRU the latest version back into older releases. Docker.io 1.12 replaced the interface to declare networks so now most (if not all) docker related subcommands of fanatic are broken in Yakkety/Xenial.

Fix: The new version adds compat code to run docker subcommands differently, depending on the docker.io version installed. In case docker.io were not upgraded, nothing changes. This should minimize regression potential.
The only other change to the upload is adding a dep8 test against docker to allow detection of future breakage sooner. As this is not part of the binary packages, this should neither add any regressions.

Testcase:
- fanatic enable -u <underlay> -o <overlay>
- fanatic enable-docker -u <underlay> -o <overlay>
- fanatic test-local-docker -u <underlay> -o <overlay>
- fanatic disable-docker -u <underlay> -o <overlay>
- <check fan bridge still is configured here>
- fanatic disable -u <underlay> -o <overlay>

See original description
Revision history for this message
Stefan Bader (smb) wrote :

Would we want to upload to yakkety and forward copy to zesty or upload two versions with the same code? In the end we want to switch zesty from 0.12 to 0.13 anyway.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-fan - 0.12.1

---------------
ubuntu-fan (0.12.1) zesty; urgency=low

  * fanatic: Support new (>=1.12) docker network management commands
    (LP: #1656875).
  * dep8: Added ADT test case for docker. This also required a minor change
    to the test setup in fanatic to suppress output to stderr.

 -- Stefan Bader <email address hidden> Tue, 17 Jan 2017 14:26:49 +0100

Changed in ubuntu-fan (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Thanks for submitting the SRU! That being said, could you please include the Impact, Test Case and Regression Potential bits from the SRU template in the description? (https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template) This would give us, the reviewers, a better overview of the changes and also help out in final bug verification after accepting this package to -proposed.

Thank you!

Stefan Bader (smb)
description: updated
Stefan Bader (smb)
Changed in ubuntu-fan (Ubuntu Yakkety):
importance: Undecided → Medium
status: New → Fix Committed
Changed in ubuntu-fan (Ubuntu Xenial):
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Stefan, or anyone else affected,

Accepted ubuntu-fan into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-fan/0.12.0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Stefan, or anyone else affected,

Accepted ubuntu-fan into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-fan/0.9.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Stefan Bader (smb) wrote :

On Yakkety:

ii ubuntu-fan 0.12.0.1
ii docker.io 1.12.3-0ubuntu4~16.10.2

fanctl show
Bridge Underlay Overlay Flags
fan-250 10.1.203.53/16 250.0.0.0/8 enable dhcp

Local docker test successful and bridge still configured after disabling docker.

tags: added: verification-done-yakkety verification-needed-xenial
removed: verification-needed
Revision history for this message
Stefan Bader (smb) wrote :

On Xenial:

ii ubuntu-fan 0.9.2
ii docker.io 1.12.3-0ubuntu4~16.04.2

fanctl show
Bridge Underlay Overlay Flags
fan-250 10.1.245.52/16 250.0.0.0/8 enable dhcp

Local docker test successful and bridge still configured after disabling docker.

tags: added: verification-done-xenial
removed: verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-fan - 0.12.0.1

---------------
ubuntu-fan (0.12.0.1) yakkety; urgency=low

  * fanatic: Support new (>=1.12) docker network management commands
    (LP: #1656875).
  * dep8: Added ADT test case for docker. This also required a minor change
    to the test setup in fanatic to suppress output to stderr.

 -- Stefan Bader <email address hidden> Mon, 16 Jan 2017 17:01:42 +0100

Changed in ubuntu-fan (Ubuntu Yakkety):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for ubuntu-fan has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-fan - 0.9.2

---------------
ubuntu-fan (0.9.2) xenial; urgency=medium

  * fanatic: Support new (>=1.12) docker network management commands
    (LP: #1656875).
  * dep8: Added ADT test case for docker. This also required a minor change
    to the test setup in fanatic to suppress output to stderr.

 -- Stefan Bader <email address hidden> Fri, 20 Jan 2017 17:54:11 +0100

Changed in ubuntu-fan (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.