Mahara

SmartEvidence framework assment feedback not working

Bug #1656974 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 17.04.0
16.10
Fix Released
High
Unassigned
Mahara 16.10.3
17.04
Fix Released
High
Robert Lyon
Mahara 17.04.0

Bug Description

The system is trying to save the wrong evidence ID as the framework ID for framework assessment feedback - so it will work when there are less evidences than there are frameworks - but breaks once there are more.

Need to fix up to save correct framework ID

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 17.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7400

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7400
Committed: https://git.mahara.org/mahara/mahara/commit/4183c6acf1f3658ce89ddf513e5e0f90ec2d51b9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4183c6acf1f3658ce89ddf513e5e0f90ec2d51b9
Author: Robert Lyon <email address hidden>
Date: Tue Jan 17 13:06:45 2017 +1300

Bug 1656974: Fixing the saving of wrong id when altering feedback

On a SmartEvidence framework where we change the feedback status

behatnotneeded

Change-Id: I1078d0c921381932f717defecd0bdc2f1bc2d246
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7407

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7407
Committed: https://git.mahara.org/mahara/mahara/commit/37d410eaff98cd97162235c7f47633523630f6d7
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 37d410eaff98cd97162235c7f47633523630f6d7
Author: Robert Lyon <email address hidden>
Date: Tue Jan 17 13:06:45 2017 +1300

Bug 1656974: Fixing the saving of wrong id when altering feedback

On a SmartEvidence framework where we change the feedback status

behatnotneeded

Change-Id: I1078d0c921381932f717defecd0bdc2f1bc2d246
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4183c6acf1f3658ce89ddf513e5e0f90ec2d51b9)

Kristina Hoeppner (kris-hoeppner)
summary: - smart evidence framework assment feedback not working
+ SmartEvidence framework assment feedback not working
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.