os-prober fails to see other installed systems

Status changed to 'Confirmed' because the bug affects multiple users.

Disk partitioning :

Disk /dev/sdb: 111.8 GiB, 120034123776 bytes, 234441648 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0x8736edad

Device Boot Start End Sectors Size Id Type
/dev/sdb1 * 4094 234441647 234437554 111.8G 5 Extended
/dev/sdb5 4096 51203314 51199219 24.4G 83 Linux
/dev/sdb6 51206144 92167081 40960938 19.5G 83 Linux
/dev/sdb7 92170240 122890943 30720704 14.7G 83 Linux
/dev/sdb8 122894336 149517382 26623047 12.7G 83 Linux

sd6 is the partition which was / when running update-grub.

sdb5 is Xenial
sdb7 is Yakkety
sdb8 is a newer Zesty

This bug was fixed in the package os-prober - 1.73ubuntu3

---------------
os-prober (1.73ubuntu3) zesty; urgency=medium

  * Think-o; re-add the is_dos_extended() function in common.sh which went
    missing. This is the right fix for the removal of the test in main
    os-prober, but is still required elsewhere in os-prober. (LP: #1660159)

 -- Mathieu Trudel-Lapierre <email address hidden> Tue, 31 Jan 2017 16:38:20 -0500

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
http://iso.qa.ubuntu.com/qatracker/reports/bugs/1660159

I've gotten report from flocculant that os-prober still fails to see other OSes in his setup; re-opening. Is anyone else able to reproduce the issue?

Yesterday os-prober was upgraded to 1.73ubuntu3. Today, doing a cold boot, the grub menu only list this zesty entries, all the other installations has been missed.
Purging then reinstalling it does nothing better. Running update-grub does not list the other installations.
Downgrading to 1.70 version for now.

Note about 30_os-prober script with os-prober 1.73.x

when edited with file, i'm seeing some ' $( ) ' red highlighted, mainly into the osx_entry() section, but also ' #/boot '

so it looks like some syntaxes are not valid/accepted, but not all (some $() & {} are highlighted, some are not)

10_linux & 00_header (/etc/grub.d/) also show these red hightlighted syntaxes

no output for " sudo os-prober " (old hardware with a bios only)

currently happening on Zesty ISO's for install

On Thu, Feb 02, 2017 at 06:47:34AM -0000, dino99 wrote:
> when edited with file, i'm seeing some ' $( ) ' red highlighted, mainly
> into the osx_entry() section, but also ' #/boot '

That's just vim being excessively conservative by default. Its sh
syntax highlighter defaults to the very old Bourne shell, but every
legitimate /bin/sh implementation on Ubuntu is a POSIX shell (based on
the Korn shell) which is somewhat more capable. ":let g:is_posix = 1"
should give the highlighter a bit more clue. See ":help sh.vim" for
more details.

None of this has anything to do with this bug.

Still affects my setup as well

In Xubuntu 17.04 it's the same .......

Reproduced with Xubuntu Zesty 20170203

The same bug after today's (20170203) Kubuntu upgrade to zesty devel: os-prober cannot detect windows xp partition.

It will carry on being the same until it's fixed - if affected then https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1660159/+affectsmetoo is enough to do

Additional information:

fdisk:
  /dev/sda2 x x x x 7 HPFS/NTFS/exFAT

syslog:
  os-prober: debug: running /usr/lib/os-probes/mounted/20microsoft on mounted /dev/sda2
  20microsoft: debug: /dev/sda2 is a FUSE partition

New fix has landed, and it works as expected now

 sudo os-prober
[sudo] password for oem:
/dev/sda1:Ubuntu Zesty Zapus (development branch) (17.04):Ubuntu:linux
/dev/sda5:Ubuntu 16.04.1 LTS (16.04):Ubuntu1:linux

os-prober (1.73ubuntu4) zesty; urgency=medium

  * Fix os-prober not detecting other OSes. Somehow the merge dropped the
    execution bits for 50mounted-tests. (LP: #1660159)

 -- Mathieu Trudel-Lapierre <email address hidden> Fri, 03 Feb 2017 14:46:41 -0500

I fixed the problem for my setup.
Afterwhile I realized that my system Windows XP partition is on /dev/sdb3, while /dev/sda2 is not bootable. os-prober detected WinXP after mounting windows xp system partition from /dev/sdb3, and grub updated as required.