HorizontalInput outputs values as string

Bug #1664975 reported by Jiri Tomasek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Jiri Tomasek

Bug Description

when a value is set in html input, it's event.target.value always renders as string. To maintain correct value type, it needs to get converted accordingly. HorizontalCheckBox takes care of booleans, HorizontalNumberInput needs to get added to convert number values correctly

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/434282

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
milestone: ocata-rc1 → ocata-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/434282
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=28db59e8b60aa0bad81265e7bd0c51f430922334
Submitter: Jenkins
Branch: master

commit 28db59e8b60aa0bad81265e7bd0c51f430922334
Author: Jiri Tomasek <email address hidden>
Date: Wed Feb 15 14:51:24 2017 +0100

    Add HorizontalNumberInput

    HorizontalNumberInput converts value string to number

    Closes-Bug: #1664975
    Change-Id: I29a401739b3a45c7ba4fb808c46d8909ac58ef4e

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/437690

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (stable/ocata)

Reviewed: https://review.openstack.org/437690
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=d3e7b1b0edc98ece0e7369621551de6a7b835853
Submitter: Jenkins
Branch: stable/ocata

commit d3e7b1b0edc98ece0e7369621551de6a7b835853
Author: Jiri Tomasek <email address hidden>
Date: Wed Feb 15 14:51:24 2017 +0100

    Add HorizontalNumberInput

    HorizontalNumberInput converts value string to number

    Closes-Bug: #1664975
    Change-Id: I29a401739b3a45c7ba4fb808c46d8909ac58ef4e
    (cherry picked from commit 28db59e8b60aa0bad81265e7bd0c51f430922334)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ui 3.1.0

This issue was fixed in the openstack/tripleo-ui 3.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ui 7.0.0

This issue was fixed in the openstack/tripleo-ui 7.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.