[PATCH] Accessibility partly broken due to X root window being kept from login session.

The X server is not reset between the greeter and session so the background can remain the same. This means anything set in the greeter will remain.

So the solution is probably:
- Make sure the greeter cleans up anything that it has left around
- Make the session smarter about checking if anything left by the greeter is still applicable. For example the AT_SPI_BUS value might point to a closed socket and can be ignored / overwritten.

The second is probably the most reliable, so any failure in the greeter doesn't cause the session to fail.

Can this be reviewed for lightdm-gtk-greeter, please ?
I'd like to add this commit for fedora 26 to fix the spam in logs.

...of course for fixing accessibility support in fedora 26 MATE-Compiz spin, which will be release this week.

Status changed to 'Confirmed' because the bug affects multiple users.

Hello,

Just to confirm that the approch proposed by Luke is sound. Removing the AT_SPI_BUS property would really be the safest for the user session: even if systemd doesn't manage to properly clean the at-spi dbus, at least the session isn't exposed to its existence.

Hello,
Looking at the patches I can see removal of at-spi2-bus-launcher related code however I am unable to see a fix related to cleaning up the X window root.Thus if the only patch to gtk-greeter is committed I am afraid it will leave us with broken a11y within the user session. Or should I be also looking elsewhere to see all the related activity?
I would say this is a good move prone to all kinds of various possible setups however before removing ability to spawn at-spi2-bus-launcher we should make sure there are no traces of it when it's being started by something else e.g. by orca when called with orca --replace or by GTK as part of its ATK module.
Again this only handles the case when at-spi2 is activated via systemd.
So to sumarize all the recent a11y related spam that has popped up recently:
These patches are only suitable for distros where at-spi is activated via systemd.
For systemd less distros the patch proposed by Samuel Thibauld at the LP #1366534 is so far the working solution.

Hello,

Still now news on this and #1366534 ? This is really hurting users...

I have pushed the AT_SPI_BUS removal patch to branch https://code.launchpad.net/~samuel-thibault/lightdm-gtk-greeter/at-spi-bus

Applied Samuel Thibault's patch to master, which seems like a safe solution benefiting the most users.

This bug was fixed in the package unity-greeter - 18.04.0+19.04.20190410-0ubuntu1

---------------
unity-greeter (18.04.0+19.04.20190410-0ubuntu1) disco; urgency=medium

  [ Khurshid Alam ]
  * src/list-stack.vala: Fix build with vala 0.43.x

  [ Luke Yelavich ]
  * Remove at-spi load/kill code (LP: #1670933)

 -- Marco Trevisan (Treviño) <mail@3v1n0.net> Wed, 10 Apr 2019 17:34:35 +0000