some network proxy router functions don't support id as argument

Bug #1683787 reported by Alon Bar Tzlil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack SDK
Fix Released
Undecided
Alon Bar Tzlil

Bug Description

some functions in the network proxy class related to the router object, will fail if given the router argument as id and not an instance of a router class.

the functions are the following:
add_interface_to_router
remove_interface_from_router
add_gateway_to_router
remove_gateway_from_router

a possible fix is to add a call to get_resource, similar to other functions.

Alon Bar Tzlil (aivrit)
Changed in python-openstacksdk:
assignee: nobody → Alon Bar Tzlil (aivrit)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/457647

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/457647
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=cf0e6f9cfbfd7149b5fd58756a130426a4b9243a
Submitter: Jenkins
Branch: master

commit cf0e6f9cfbfd7149b5fd58756a130426a4b9243a
Author: Alon Bar Tzlil <email address hidden>
Date: Tue Apr 18 16:55:04 2017 +0300

    Allow router related functions to receive an ID

    Add support for receiving an id as the argument for some router related
    functions in the network proxy class.

    Change-Id: Id80685bd4721f6ed12e5535fe0c6d49ecf10e135
    Closes-Bug: 1683787

Changed in python-openstacksdk:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.