Launchpad itself

Extra slashes causing mirror probe to fail

Bug #1692347 reported by Brad Koehn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Colin Watson

Bug Description

I got an email from the mirror probe telling me that my mirror was offline. The log file indicated it was getting bad results from URLs like the following:

http://mirrors.koehn.com/ubuntureleases///zesty/ubuntu-17.04-desktop-amd64.iso

Sure enough, that URL 404s when I hit it. But what's with all the extra slashes? If I navigate to my mirror and click the links to download that file, I get a URL that looks like this:

http://mirrors.koehn.com/ubuntureleases/zesty/ubuntu-17.04-desktop-amd64.iso

I'm not sure why the mirror probe is using the extra slashes, but it's causing it to incorrectly report my mirror as being down. Please fix the mirror probe!

Related branches

lp:~cjwatson/launchpad/mirror-prober-extra-slashes
William Grant: Approve (code)
Diff: 55 lines (+11/-4)
1 file modified
lib/lp/registry/scripts/distributionmirror_prober.py (+11/-4)
Revision history for this message
Colin Watson (cjwatson) wrote :

Hm. Well, we can deduplicate the slashes (one is from the trailing slash in your mirror URL, one is from a hardcoded '%s/%s' string, and one is from the start of the path field in http://releases.ubuntu.com/.manifest), but are you sure that's really what's causing the failure? Both those URLs return 200 for me, and in general extra slashes shouldn't be a problem.

Revision history for this message
Brad Koehn (l-brad-y) wrote :

I can't say for certain; I'm now also getting 200 when I HEAD those URLs. It's entirely possible it's just a burp in the interwebs.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r18388 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/18388>.

Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
tags: added: qa-needstesting
Changed in launchpad:
status: New → Fix Committed
Colin Watson (cjwatson)
tags: added: qa-untestable
removed: qa-needstesting
Revision history for this message
Colin Watson (cjwatson) wrote :

The extra slashes are gone now, and your mirror should be probed again at some point in the next couple of days. Let us know if that doesn't seem to be happening.

Changed in launchpad:
importance: Undecided → Low
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.