Removal of Babel in 3.15.2 requirements.txt breaks package

Bug #1692773 reported by Douglas Linder
44
This bug affects 10 people
Affects Status Importance Assigned to Milestone
oslo.i18n
Fix Released
Undecided
Akihiro Motoki

Bug Description

https://github.com/openstack/oslo.i18n/commit/0658992b0b9bb8a9ad71ddf962d89d3ede27b95e removed Babel as a dependency of oslo.i18n

However, this package is imported at runtime, see:

https://github.com/openstack/oslo.i18n/blob/master/oslo_i18n/__init__.py#L14

https://github.com/openstack/oslo.i18n/blob/master/oslo_i18n/_gettextutils.py#L24

This is a breaking change; oslo.i18n can no longer be imported without and error, which breaks oslo.concurrency:

  File "./renderer/fonts.py", line 9, in <module>
    from oslo_concurrency import lockutils
  File ".../lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 33, in <module>
    from oslo_concurrency._i18n import _, _LI
  File ".../lib/python2.7/site-packages/oslo_concurrency/_i18n.py", line 17, in <module>
    import oslo_i18n
  File ".../lib/python2.7/site-packages/oslo_i18n/__init__.py", line 14, in <module>
    from ._gettextutils import *
  File ".../lib/python2.7/site-packages/oslo_i18n/_gettextutils.py", line 24, in <module>
    from babel import localedata
ImportError: No module named babel

I'm not sure what the motivation behind https://github.com/openstack/oslo.i18n/commit/0658992b0b9bb8a9ad71ddf962d89d3ede27b95e was, but it's wrong; babel is a runtime requirement.

Revision history for this message
Akihiro Motoki (amotoki) wrote :

Due to this bug, oslo.i18n 3.15.2 is completely broken.

summary: - Removal of Babel in 3.15.1 requirements.txt breaks package
+ Removal of Babel in 3.15.2 requirements.txt breaks package
Revision history for this message
Akihiro Motoki (amotoki) wrote :

- oslo.i18n review https://review.openstack.org/467002 reverts the commit of the requirement change.
- global-requirement change which block oslo.i18n 3.15.2 is here: https://review.openstack.org/#/c/467001/

Changed in oslo.i18n:
assignee: nobody → Akihiro Motoki (amotoki)
Revision history for this message
Alan Pevec (apevec) wrote :

I've also proposed new Pike release of oslo.i18n 3.15.3 https://review.openstack.org/465488

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.i18n 3.15.3

This issue was fixed in the openstack/oslo.i18n 3.15.3 release.

Changed in oslo.i18n:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.