Bug #1698592 “[needs-packaging] qtvirtualkeyboard-opensource-src...” : Bugs : qtvirtualkeyboard-opensource-src package : Ubuntu

Revision history for this message

Clive Johnston (clivejo) wrote on 2017-06-17:

#1

Using the packaging from Alioth, I have been testing this package via KCI unstable PPA

https://launchpad.net/~kubuntu-ci/+archive/ubuntu/unstable/+build/12671011

All is working as expected.

Ubuntu Foundations Team Bug Bot (crichton) on 2017-06-18

tags:

added: needs-packaging

Revision history for this message

Brian Murray (brian-murray) wrote on 2017-06-18:

#2

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

Changed in ubuntu:
importance:	Undecided → Wishlist

Revision history for this message

Bhavani Shankar (bhavi) wrote on 2017-06-19:

#3

Download full text (11.0 KiB)

Again looks good except a few things which are minor

$ check-all-the-things
# Check with upstream where the Inkscape SVG source files are.
$ find . -type f $ -iname '*.png' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' $ -exec grep -nHiF inkscape {} +
Binary file ./src/virtualkeyboard/doc/images/gesture-double-up.png matches
Binary file ./src/virtualkeyboard/doc/images/gesture-single-right.png matches
Binary file ./src/virtualkeyboard/doc/images/gesture-single-down-left.png matches
Binary file ./src/virtualkeyboard/doc/images/gesture-single-up.png matches
Binary file ./src/virtualkeyboard/doc/images/gesture-single-left.png matches
Binary file ./src/virtualkeyboard/doc/images/gesture-double-left.png matches

# Please check if these directories contain embedded code/data copies.
# Please remove any embedded copies from the upstream VCS and tarballs.
# https://wiki.debian.org/EmbeddedCodeCopies
$ find . -type d -name 'vendor*' -o -iname '*rd*party' -o -iname 3rdp -o -name contrib -o -name imports -o -name node_modules -o -iname external -o -iname deps -o -name inc
./src/virtualkeyboard/3rdparty

# Please check if these README files belong to embedded code/data copies.
# Please remove any embedded copies from the upstream VCS and tarballs.
# https://wiki.debian.org/EmbeddedCodeCopies
$ find . -mindepth 2 -iname '*README*'
./tests/auto/inputpanel/hwr_test_data/README.txt

# check if these can be switched to https://
$ grep -nHrF http: .
./LICENSE.GPL3:4: Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
./LICENSE.GPL3:648: along with this program. If not, see <http://www.gnu.org/licenses/>.
./LICENSE.GPL3:667:<http://www.gnu.org/licenses/>.
./LICENSE.GPL3:674:<http://www.gnu.org/philosophy/why-not-lgpl.html>.
./debian/control:20:Homepage: http://doc.qt.io/qt-5/qtvirtualkeyboard-index.html
./debian/copyright:1:Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
./debian/copyright:48: http://www.apache.org/licenses/LICENSE-2.0
./tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:7:## For any questions to The Qt Company, please use contact form at http://qt.io
./tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:17:## contact form at http://qt.io
./tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:35:** For any questions to The Qt Company, please use contact form at http://qt.io
...

$ licensecheck --check=. --recursive --copyright .
./LICENSE.GPL3: UNKNOWN
[Copyright: 2007 Free Software Foundation, Inc. <http:fsf.org/>]

./debian/control: *No copyright* UNKNOWN

./debian/rules: *No copyright* UNKNOWN

./debian/copyright: Apache (v2.0) MIT/X11 (BSD like) GPL (unversioned/unknown version)
[Copyright: 2016 The Qt Company Ltd]

...

$ licensecheck --check=. --recursive --copyright . | grep -aF 'GENERATED FILE'
./tests/auto/inputpanel/hwr_test_data/README.txt: *No copyright* GENERATED FILE
./src/virtualkeyboard/generateresource.pri: *No copyright* GENERATED FILE
./src/virtualkeyboard/3rdparty/openwnn/NOTICE: *No copyright* GENERATED FILE
./src/virtualkeyboard/import/plugins.qmltypes: *No copyright* GENERATED FILE

$ env PERL5OPT=-m-lib=. lintian --info --display-info --displa...

Again looks good except a few things which are minor

$ check-all-the-things 
# Check with upstream where the Inkscape SVG source files are.
$ find . -type f $ -iname '*.png' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' $ -exec grep -nHiF inkscape {} +
Binary file ./src/virtualkeyboard/doc/images/gesture-double-up.png matches
Binary file ./src/virtualkeyboard/doc/images/gesture-single-right.png matches
Binary file ./src/virtualkeyboard/doc/images/gesture-single-down-left.png matches
Binary file ./src/virtualkeyboard/doc/images/gesture-single-up.png matches
Binary file ./src/virtualkeyboard/doc/images/gesture-single-left.png matches
Binary file ./src/virtualkeyboard/doc/images/gesture-double-left.png matches

# Please check if these directories contain embedded code/data copies.
# Please remove any embedded copies from the upstream VCS and tarballs.
# https://wiki.debian.org/EmbeddedCodeCopies
$ find . -type d -name 'vendor*' -o -iname '*rd*party' -o -iname 3rdp -o -name contrib -o -name imports -o -name node_modules -o -iname external -o -iname deps -o -name inc
./src/virtualkeyboard/3rdparty

# Please check if these README files belong to embedded code/data copies.
# Please remove any embedded copies from the upstream VCS and tarballs.
# https://wiki.debian.org/EmbeddedCodeCopies
$ find . -mindepth 2 -iname '*README*'
./tests/auto/inputpanel/hwr_test_data/README.txt

# check if these can be switched to https://
$ grep -nHrF http: .
./LICENSE.GPL3:4: Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
./LICENSE.GPL3:648:    along with this program.  If not, see <http://www.gnu.org/licenses/>.
./LICENSE.GPL3:667:<http://www.gnu.org/licenses/>.
./LICENSE.GPL3:674:<http://www.gnu.org/philosophy/why-not-lgpl.html>.
./debian/control:20:Homepage: http://doc.qt.io/qt-5/qtvirtualkeyboard-index.html
./debian/copyright:1:Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
./debian/copyright:48: http://www.apache.org/licenses/LICENSE-2.0
./tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:7:## For any questions to The Qt Company, please use contact form at http://qt.io
./tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:17:## contact form at http://qt.io
./tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:35:** For any questions to The Qt Company, please use contact form at http://qt.io
...

$ licensecheck --check=. --recursive --copyright .
./LICENSE.GPL3: UNKNOWN
  [Copyright: 2007 Free Software Foundation, Inc. <http:fsf.org/>]

./debian/control: *No copyright* UNKNOWN

./debian/rules: *No copyright* UNKNOWN

./debian/copyright: Apache (v2.0) MIT/X11 (BSD like) GPL (unversioned/unknown version)
  [Copyright: 2016 The Qt Company Ltd]

...

$ licensecheck --check=. --recursive --copyright . | grep -aF 'GENERATED FILE'
./tests/auto/inputpanel/hwr_test_data/README.txt: *No copyright* GENERATED FILE
./src/virtualkeyboard/generateresource.pri: *No copyright* GENERATED FILE
./src/virtualkeyboard/3rdparty/openwnn/NOTICE: *No copyright* GENERATED FILE
./src/virtualkeyboard/import/plugins.qmltypes: *No copyright* GENERATED FILE

$ env PERL5OPT=-m-lib=. lintian --info --display-info --display-experimental --pedantic --show-overrides --color auto
Cannot find changes file for qtvirtualkeyboard-opensource-src/5.7.1-1ubuntu1~kci~artful1, tried:
  qtvirtualkeyboard-opensource-src_5.7.1-1ubuntu1~kci~artful1_amd64.changes
  qtvirtualkeyboard-opensource-src_5.7.1-1ubuntu1~kci~artful1_i386.changes
  qtvirtualkeyboard-opensource-src_5.7.1-1ubuntu1~kci~artful1_multi.changes
  qtvirtualkeyboard-opensource-src_5.7.1-1ubuntu1~kci~artful1_all.changes
  qtvirtualkeyboard-opensource-src_5.7.1-1ubuntu1~kci~artful1_source.changes
 in the following dirs:
  ..
  ../build-area
  /var/cache/pbuilder/result

$ find . -type f -iname '*.py' -exec pyflakes3 {} +
./tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:47:82: invalid syntax
******************************************************************************/""" % datetime.datetime.now().year
                                                                                 ^

$ find . -type f -iname '*.py' -exec pylint --rcfile=/dev/null --msg-template='{path}:{line}:{column}: [{category}:{symbol}] {obj}: {msg}' --reports=n {} +
************* Module build_unipen_data
tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:47:0: [convention:line-too-long] : Line too long (113/100)
tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:113:0: [convention:line-too-long] : Line too long (104/100)
tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:57:0: [warning:redefined-builtin] help: Redefining built-in 'help'
tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:1:0: [convention:missing-docstring] : Missing module docstring
tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:28:0: [convention:invalid-name] : Invalid constant name "unipen_file_pattern"
tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:30:0: [convention:missing-docstring] print_header: Missing function docstring
tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:49:0: [convention:missing-docstring] scan_unipen_files: Missing function docstring
tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:51:14: [warning:unused-variable] scan_unipen_files: Unused variable 'dirs'
tests/auto/inputpanel/hwr_test_data/build_unipen_data.py:57:0: [convention:missing-docstring] help: Missing function docstring
...

$ find . -type d $ -iname .bzr -o -iname .git -o -iname .hg -o -iname .svn -o -iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o -iname _darcs -o -iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o -iname .metadata -o -iname CMakeFiles -o -iname _build -o -iname _sgbak -o -iname autom4te.cache -o -iname blib -o -iname cover_db -o -iname node_modules -o -iname '~.dep' -o -iname '~.dot' -o -iname '~.nib' -o -iname '~.plst' $ -prune -o -type f ! $ -iname '*.bak' -o -iname '*.swp' -o -iname '#.*' -o -iname '#*#' -o -iname 'core.*' -o -iname '*~' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' -o -iname '*.png' -o -iname '*.min.js' -o -iname '*.js.map' -o -iname '*.js.min' -o -iname '*.min.css' -o -iname '*.css.map' -o -iname '*.css.min' -o -iname '*.wav' $ -exec env PERL5OPT=-m-lib=. spellintian --picky {} +
./tests/auto/inputpanel/hwr_test_data/build_unipen_data.py: print print (duplicate word) -> print
./tests/auto/inputpanel/hwr_test_data/build_unipen_data.py: python -> Python
./tests/auto/inputpanel/data/inputpanel/handwriting.js: t t (duplicate word) -> t
./src/virtualkeyboard/doc/src/qtvirtualkeyboard-index.qdoc: Portugese -> Portuguese
./src/virtualkeyboard/abstractinputmethod.cpp: the the (duplicate word) -> the
./src/virtualkeyboard/abstractinputmethod.cpp: futher -> further
./src/virtualkeyboard/trace.cpp: of of (duplicate word) -> of
./src/virtualkeyboard/inputengine.cpp: Pinyin Pinyin (duplicate word) -> Pinyin
./src/virtualkeyboard/inputengine.cpp: Cangjie Cangjie (duplicate word) -> Cangjie
./src/virtualkeyboard/inputengine.cpp: Zhuyin Zhuyin (duplicate word) -> Zhuyin
...

$ suspicious-source
./src/virtualkeyboard/3rdparty/tcime/data/qt/dict_phrases.dat
./src/virtualkeyboard/3rdparty/tcime/data/qt/dict_cangjie.dat
./src/virtualkeyboard/3rdparty/tcime/data/qt/dict_zhuyin.dat
./src/virtualkeyboard/3rdparty/tcime/data/java/dict_phrases.dat
./src/virtualkeyboard/3rdparty/tcime/data/java/dict_cangjie.dat
./src/virtualkeyboard/3rdparty/tcime/data/java/dict_zhuyin.dat
./src/virtualkeyboard/3rdparty/tcime/tools/dict2qt.class
./src/virtualkeyboard/3rdparty/lipi-toolkit/projects/alphanumeric/config/default/nn.mdt
./src/virtualkeyboard/3rdparty/pinyin/data/dict_pinyin.dat

$ grep -nHr '/tmp/' .
./debian/rules:21:	rm -vf $(CURDIR)/debian/tmp/usr/lib/*/cmake/Qt5Gui/Qt5Gui_QVirtualKeyboardPlugin.cmake

$ grep -nHriE 'fixme|todo|hack|xxx+|broken' .
./tests/auto/inputpanel/data/tst_inputpanel.qml:227:                { initText: "xxxxxx", initInputMethodHints: Qt.ImhNoPredictiveText | Qt.ImhNoAutoUppercase, inputKey: Qt.Key_Backspace, keyHold: 1000, outputKeyCountMin: 6, outputKey: Qt.Key_Backspace, preview: false, outputKeyText: "", outputKeyModifiers: Qt.NoModifier, outputKeyRepeat: true, outputText: "" },
./src/virtualkeyboard/doc/snippets/CustomInputMethod.qml:49:        // TODO: reset the input method without modifying input context
./src/virtualkeyboard/doc/snippets/CustomInputMethod.qml:53:        // TODO: commit current state and update the input method
./src/virtualkeyboard/doc/snippets/CustomInputMethod.qml:58:        // TODO: Handle key and set accept or fallback to default processing
Binary file ./src/virtualkeyboard/3rdparty/tcime/data/qt/dict_phrases.dat matches
Binary file ./src/virtualkeyboard/3rdparty/tcime/data/java/dict_phrases.dat matches
./src/virtualkeyboard/3rdparty/openwnn/wnnDictionary/include/nj_err.h:57:#define NJ_ERR_DIC_BROKEN                           (0x2200) 
./src/virtualkeyboard/3rdparty/openwnn/wnnDictionary/include/nj_err.h:62:#define NJ_ERR_CACHE_BROKEN                         (0x2D00) 
./src/virtualkeyboard/3rdparty/openwnn/wnnDictionary/engine/ndbdic.c:923:                            return NJ_SET_ERR_VAL(NJ_FUNC_NJD_B_SEARCH_WORD, NJ_ERR_DIC_BROKEN); 
./src/virtualkeyboard/3rdparty/openwnn/wnnDictionary/engine/ndbdic.c:1756:                        return NJ_SET_ERR_VAL(NJ_FUNC_NJD_B_SEARCH_WORD, NJ_ERR_CACHE_BROKEN); 
...

$ test -d ./debian &&
! grep -sq native debian/source/format &&
! test -e debian/upstream/metadata &&
echo 'Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata'
Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata

$ env PERL5OPT=-m-lib=. uscan --report-status --no-verbose
uscan: Newest version of qtvirtualkeyboard-opensource-src on remote site is 5.9.0, local version is 5.7.1
uscan:    => Newer package available from
      https://download.qt.io/official_releases/qt/5.9/5.9.0/submodules/qtvirtualkeyboard-opensource-src-5.9.0.tar.xz

check all things run says that there is a new upstream version available. Could have a look at updating the same

There are few missing docstrings and syntax error(s) in py files which can be taken a look at.

$ lintian -I -E --pedantic qtvirtualkeyboard-opensource-src_5.7.1-1ubuntu1~kci~artful1.dsc
I: qtvirtualkeyboard-opensource-src source: wildcard-matches-nothing-in-dep5-copyright src/virtualkeyboard/3rdparty/lipi-toolkit/ (paragraph at line 19)
I: qtvirtualkeyboard-opensource-src source: wildcard-matches-nothing-in-dep5-copyright src/virtualkeyboard/3rdparty/tcime (paragraph at line 38)
I: qtvirtualkeyboard-opensource-src source: wildcard-matches-nothing-in-dep5-copyright src/virtualkeyboard/3rdparty/pinyun (paragraph at line 38)
I: qtvirtualkeyboard-opensource-src source: wildcard-matches-nothing-in-dep5-copyright ... use --no-tag-display-limit to see all (or pipe to a file/program)
I: qtvirtualkeyboard-opensource-src source: unused-file-paragraph-in-dep5-copyright paragraph at line 19
I: qtvirtualkeyboard-opensource-src source: unused-file-paragraph-in-dep5-copyright paragraph at line 38
P: qtvirtualkeyboard-opensource-src source: debian-watch-may-check-gpg-signature

Few minor things that can be looked into

Thanks!

Revision history for this message

Jeremy Bícha (jbicha) wrote on 2017-06-19:

#4

I assume the 5.9 version requires Qt 5.9 which is not in Ubuntu yet.

Revision history for this message

Clive Johnston (clivejo) wrote on 2017-07-10:

#5

https://buildd.debian.org/status/package.php?p=qtvirtualkeyboard-opensource-src

Revision history for this message

Jeremy Bícha (jbicha) wrote on 2017-07-10:

#6

Thanks Clive. This should autosync to Ubuntu soon (maybe later today or tomorrow).

Changed in ubuntu:
status:	New → Fix Committed

Revision history for this message

Clive Johnston (clivejo) wrote on 2017-07-10:

#7

Would you mind keeping an eye on it and poking it with a big stick if required? We kinda need this package to allow the on-screen keyboard to log in for the KDE Plasma desktop.

Many thanks :)

Jeremy Bícha (jbicha) on 2017-07-10

affects:

ubuntu → qtvirtualkeyboard-opensource-src (Ubuntu)

Revision history for this message

Jeremy Bícha (jbicha) wrote on 2017-07-11:

#8

https://launchpad.net/ubuntu/+source/qtvirtualkeyboard-opensource-src/5.7.1+dfsg-1

Changed in qtvirtualkeyboard-opensource-src (Ubuntu):
status:	Fix Committed → Fix Released

Affects		Status	Importance	Assigned to	Milestone
	qtvirtualkeyboard-opensource-src (Ubuntu)	Fix Released	Wishlist	Unassigned
Nominated for Artful by Clive Johnston

Ubuntu
qtvirtualkeyboard-opensource-src package

[needs-packaging] qtvirtualkeyboard-opensource-src

Bug Description

Other bug subscribers

Remote bug watches

Ubuntuqtvirtualkeyboard-opensource-src package

[needs-packaging] qtvirtualkeyboard-opensource-src

Bug Description

Other bug subscribers

Remote bug watches

Ubuntu
qtvirtualkeyboard-opensource-src package