Rabbitmq class expects ports as integers, not strings

Fix proposed to branch: master
Review: https://review.openstack.org/498711

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/498711
Reason: I need to purge the gate because TripleO CI gate has critical issues right now, I'll make this patch goes to the gate.

Reviewed: https://review.openstack.org/498711
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=4bea8cf918463c43c7d5f4e46984ab54271ea3e5
Submitter: Jenkins
Branch: master

commit 4bea8cf918463c43c7d5f4e46984ab54271ea3e5
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Tue Aug 29 08:22:30 2017 +0000

    Use integers for rabbitmq ports

    They should be integers as specified in the parameter definition
    of the class. Else it'll fail.

    Change-Id: I06b6e46c0722516e28e8bff4d481fb4b7a08bd61
    Closes-Bug: #1713659

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/499125

Reviewed: https://review.openstack.org/499125
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2dece06fee484153120d5153de8ea4d9158298a9
Submitter: Jenkins
Branch: stable/pike

commit 2dece06fee484153120d5153de8ea4d9158298a9
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Tue Aug 29 08:22:30 2017 +0000

    Use integers for rabbitmq ports

    They should be integers as specified in the parameter definition
    of the class. Else it'll fail.

    Change-Id: I06b6e46c0722516e28e8bff4d481fb4b7a08bd61
    Closes-Bug: #1713659
    (cherry picked from commit 4bea8cf918463c43c7d5f4e46984ab54271ea3e5)

Fix proposed to branch: master
Review: https://review.openstack.org/500798

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/500926

Reviewed: https://review.openstack.org/500798
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=cc75481ac75d74823e051ef3b4837e74c3a2e780
Submitter: Jenkins
Branch: master

commit cc75481ac75d74823e051ef3b4837e74c3a2e780
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Tue Sep 5 15:34:26 2017 +0300

    Use integer for rabbitmq port and specify management IP

    The port is being enforced in the puppet-rabbitmq manifest. The
    management IP is needed in order to for the rabbitmq admin configuration
    to work correctly. Else it'll try to poke localhost, and it'll fail.

    Change-Id: Ica0f6dd347cd56b75c22b370bd0aed5b4454f674
    Closes-Bug: #1713659

Reviewed: https://review.openstack.org/500926
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=3737e1fbc55f210bd989f883dc5ae108b895c819
Submitter: Jenkins
Branch: stable/pike

commit 3737e1fbc55f210bd989f883dc5ae108b895c819
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Tue Sep 5 15:34:26 2017 +0300

    Use integer for rabbitmq port and specify management IP

    The port is being enforced in the puppet-rabbitmq manifest. The
    management IP is needed in order to for the rabbitmq admin configuration
    to work correctly. Else it'll try to poke localhost, and it'll fail.

    Change-Id: Ica0f6dd347cd56b75c22b370bd0aed5b4454f674
    Closes-Bug: #1713659
    (cherry picked from commit cc75481ac75d74823e051ef3b4837e74c3a2e780)

hi:

i have test your fix released , but appears to new problems :

error logs:

look forward to your reply！

thank you！

<email address hidden>

From: OpenStack Infra
Date: 2017-09-06 08:27
To: chenjiengu
Subject: [Bug 1713659] Fix merged to instack-undercloud (stable/pike)
Reviewed: https://review.openstack.org/500926
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=3737e1fbc55f210bd989f883dc5ae108b895c819
Submitter: Jenkins
Branch: stable/pike

commit 3737e1fbc55f210bd989f883dc5ae108b895c819
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Tue Sep 5 15:34:26 2017 +0300

    Use integer for rabbitmq port and specify management IP

    The port is being enforced in the puppet-rabbitmq manifest. The
    management IP is needed in order to for the rabbitmq admin configuration
    to work correctly. Else it'll try to poke localhost, and it'll fail.

    Change-Id: Ica0f6dd347cd56b75c22b370bd0aed5b4454f674
    Closes-Bug: #1713659
    (cherry picked from commit cc75481ac75d74823e051ef3b4837e74c3a2e780)

--
You received this bug notification because you are subscribed to a
duplicate bug report (1715079).
https://bugs.launchpad.net/bugs/1713659

Title:
  Rabbitmq class expects ports as integers, not strings

Status in tripleo:
  Fix Released

Bug description:
  This commit https://github.com/voxpupuli/puppet-
  rabbitmq/commit/5d6e285b3099703a7d039d0be54ea8a8955ef635 merged
  specifying the rabbitmq port as an Integer, however, we pass it as a
  string. So it'll fail.

To manage notifications about this bug go to:
https://bugs.launchpad.net/tripleo/+bug/1713659/+subscriptions

Robert, how did you apply the fix?

hi:
step 1:

#service initial
systemctl enable network
systemctl disable firewalld
systemctl stop firewalld
systemctl disable NetworkManager

step 2:
#create deployment user "user:stack" "passwd:123456"

sudo useradd stack
echo '123456'| passwd --stdin stack
echo "stack ALL=(root) NOPASSWD:ALL" | sudo tee -a /etc/sudoers.d/stack
sudo chmod 0440 /etc/sudoers.d/stack
su - stack
step 3:
#create tripleo repo

sudo curl -L -o /etc/yum.repos.d/delorean.repo https://trunk.rdoproject.org/centos7-master/current-tripleo/delorean.repo
sudo curl -L -o /etc/yum.repos.d/delorean-current.repo https://trunk.rdoproject.org/centos7/current/delorean.repo
sudo sed -i 's/\[delorean\]/\[delorean-current\]/' /etc/yum.repos.d/delorean-current.repo
sudo /bin/bash -c "cat <<EOF>>/etc/yum.repos.d/delorean-current.repo

includepkgs=diskimage-builder,instack,instack-undercloud,os-apply-config,os-collect-config,os-net-config,os-refresh-config,python-tripleoclient,openstack-tripleo-common*,openstack-tripleo-heat-templates,openstack-tripleo-image-elements,openstack-tripleo,openstack-tripleo-puppet-elements,openstack-puppet-modules,openstack-tripleo-ui,puppet-*
EOF"

sudo curl -L -o /etc/yum.repos.d/delorean-deps.repo https://trunk.rdoproject.org/centos7/delorean-deps.repo
step 4:
sudo yum -y install yum-plugin-priorities
sudo yum install -y python-tripleoclient
cp /usr/share/instack-undercloud/undercloud.conf.sample ~/undercloud.conf
export DIB_INSTALLTYPE_puppet_modules=source
step 5:
edit undercloud.conf
step 6:
exec "openstack undercloud install " to deployment undercloud

but it's failed.

I want to know , why make the same repo and git clone puppet-modules contents is different?

==>
<puppet-openstack.tar.gz>
<testing.tar.gz>

<email address hidden>

From: Juan Antonio Osorio Robles
Date: 2017-09-06 12:56
To: chenjiengu
Subject: [Bug 1713659] Re: Rabbitmq class expects ports as integers, not strings
Robert, how did you apply the fix?

--
You received this bug notification because you are subscribed to a
duplicate bug report (1715079).
https://bugs.launchpad.net/bugs/1713659

Title:
  Rabbitmq class expects ports as integers, not strings

Status in tripleo:
  Fix Released

Bug description:
  This commit https://github.com/voxpupuli/puppet-
  rabbitmq/commit/5d6e285b3099703a7d039d0be54ea8a8955ef635 merged
  specifying the rabbitmq port as an Integer, however, we pass it as a
  string. So it'll fail.

To manage notifications about this bug go to:
https://bugs.launchpad.net/tripleo/+bug/1713659/+subscriptions

hi:

when you fix the "[Bug 1713659]< Rabbitmq class expects ports as integers, not strings>",

I am continue to deployment undercloud ,

exec "openstack undercloud install " to deployment undercloud

but it's failed.

appears to new bug:

Error: Evaluation Error: Error while evaluating a Function Call, Could not find class ::archive for undercloud.domain.com at /etc/puppet/modules/rabbitmq/manifests/install/rabbitmqadmin.pp:4:3 on node undercloud.domain.com

<email address hidden>

From: Juan Antonio Osorio Robles
Date: 2017-09-06 12:56
To: chenjiengu
Subject: [Bug 1713659] Re: Rabbitmq class expects ports as integers, not strings
Robert, how did you apply the fix?

--
You received this bug notification because you are subscribed to a
duplicate bug report (1715079).
https://bugs.launchpad.net/bugs/1713659

Title:
  Rabbitmq class expects ports as integers, not strings

Status in tripleo:
  Fix Released

Bug description:
  This commit https://github.com/voxpupuli/puppet-
  rabbitmq/commit/5d6e285b3099703a7d039d0be54ea8a8955ef635 merged
  specifying the rabbitmq port as an Integer, however, we pass it as a
  string. So it'll fail.

To manage notifications about this bug go to:
https://bugs.launchpad.net/tripleo/+bug/1713659/+subscriptions

Robert, that's strange... it's working in upstream CI, and the puppet-archive should be provided by the package dependencies. Gotta investigate.

hi:

I hope your team solve the problems .

look forward to your reply!

thank you!

<email address hidden>

From: Juan Antonio Osorio Robles
Date: 2017-09-06 14:42
To: chenjiengu
Subject: [Bug 1713659] Re: Rabbitmq class expects ports as integers, not strings
Robert, that's strange... it's working in upstream CI, and the puppet-
archive should be provided by the package dependencies. Gotta
investigate.

--
You received this bug notification because you are subscribed to a
duplicate bug report (1715079).
https://bugs.launchpad.net/bugs/1713659

Title:
  Rabbitmq class expects ports as integers, not strings

Status in tripleo:
  Fix Released

Bug description:
  This commit https://github.com/voxpupuli/puppet-
  rabbitmq/commit/5d6e285b3099703a7d039d0be54ea8a8955ef635 merged
  specifying the rabbitmq port as an Integer, however, we pass it as a
  string. So it'll fail.

To manage notifications about this bug go to:
https://bugs.launchpad.net/tripleo/+bug/1713659/+subscriptions

I think it just took a while for the fix to propagate. I tried a fresh quickstart install yesterday and encountered the problem, and it's working for me today. Just look for correct value (integer, not string) in undercloud's /usr/share/instack-undercloud/puppet-stack-config/puppet-stack-config.yaml.template

This issue was fixed in the openstack/instack-undercloud 7.4.0 release.

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0rc2 release candidate.

This issue was fixed in the openstack/instack-undercloud 8.0.0 release.

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.