Merging Bib Records Deletes Bookbag entries

patch: eded258f532dc9d24d4604f7eedfd33a27e8f00a
user/rogan/lp1731960_replace_bookbags_in_merge

Patch includes the sql and a pgtap test. I considered checking for the record already existing and not replacing it but on reading related lp1485695 I realized that some people may want that number of occurrences so with it not clear what the desired behavior would be this will allow duplicates.

This works as expected, thanks Rogan. Sign off branch below:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/rogan_lp1731960_replace_bookbags_in_merge_signoff

Upgrade script at the tip of user/rogan/lp1731960_replace_bookbags_in_merge

I tested this code using the signoff branch Cesar posted. I added a book to a list and then try to merge it with another record. The other record was the lead record.

The bib merge didn't succeed. Typically, the screen refreshes after the merge and brings me to the record page for the lead record.

With the patch loaded, I remain in the bucket interface, where the two records are still listed. I see the following in the browser console:

error calling method open-ils.cat.biblio.records.merge : 500 : *** Call to [open-ils.cat.biblio.records.merge] failed for session [0.383924049703027851521744377612], thread trace [0]:
Can't use an undefined value as an ARRAY reference at /usr/local/share/perl/5.18.2/OpenILS/Application/Cat.pm line 945.

Actually, it looks like the real issue is that the merge_record_assets function isn't being created with that branch.

Gah! Never mind. I found the problem. Taking another look now.

Sorry for the earlier noise. I had forgotten that I resolved an earlier merge conflict. I apparently had left one of the conflict markers in the file, which made Evergreen unhappy. Once I properly resolved the conflict, this code worked as described. The pgtap test also passed with flying colors.

Merged to master and release 3.0. Thank you Rogan and Cesar!