indicator-applet-complete 1.18.0 icon scaling

Bug #1733301 reported by Mauro Gaspari
130
This bug affects 27 people
Affects Status Importance Assigned to Milestone
libayatana-indicator (Ubuntu)
Fix Released
Low
Unassigned
Impish
Fix Released
Low
Unassigned

Bug Description

[Impact]

 * Images loaded from filename that are not the right scale/size to
   for their target location in the UI are shown at their original
   scale/size. This means that images can be oversized in the MATE
   panel.

 * This impacts any application using the system tray on Ubuntu MATE
   that are describing the icon for the tray by file path instead of
   a stock icon name. Suck apps include most desktop Snap Packages.

 * The patch fixes this issue by applying a scaling process to any
   icons loaded by explicit path. Stock images are unaffected.

[Test Plan]

 * Install Ubuntu Mate

 * Install utm-no from the Snap Store

 * Launch utm-no and observe whether the tray shows a small square
   purple icon for the app (correct) or a large purple rectangle
   (wrong)

[Where problems could occur]

 * Due to being a base system library then images and icons might
   fail to load across the operating system, or be incorrectly
   scaled

 * The patch could be insufficient to fix the problem as described

[Other Info]

 * This patch has been applied upstream, and I have been running
   a patched installation for several weeks without issue

--- original description below ---

System: Ubuntu MATE 17.10 64bit
Kernel: 4.13.0-16-generic
indicator-applet-complete: 1.18.0

It appears that some icons on the indicator applet complete cannot scale well.
I tried this on multiple computers and fresh installations, and I can reproduce it 100% of the times. Icon on attached screenshot is from synology cloudstation drive.

As a side note, same icon scales well on Ubuntu 17.10 (gnome session), Kubuntu 17.10, and Ubuntu-Mate 16.04.

Revision history for this message
Mauro Gaspari (ilvipero) wrote :
Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

I have seen this with Qt applications such as Mumble and VLC. It is also evident with Steam.

Changed in ubuntu-mate:
status: New → Invalid
Changed in mate-indicator-applet (Ubuntu):
status: New → Confirmed
Revision history for this message
Vlad Orlov (monsta) wrote :

This looks like the notification area to me. Three dots at the left of the applet... the indicator applet doesn't have them.
You can check it yourself: right-click on these dots -> (menu appears) -> click on About menu item.

Revision history for this message
Vlad Orlov (monsta) wrote :
Revision history for this message
Mauro Gaspari (ilvipero) wrote :

Thanks for your reply. I have been busy but I am willing to provide all information needed. I took a couple of screenshots to show and explain the issue I noticed.

1. On my primary machine, I run Ubuntu-Mate 16.04 LTS. I have no problem with icon size. See attached screenshot, that shows Steam Icon being properly scaled.
When I click on the 3 dots as required, I see "Notification Area 1.12.2. However if i remove it from my panel, Steam and CloudStation indicators are still visible. The applet that brings indicators is "Indicator Applet Complete 1.12.1". I tried removing and re-adding it and I can confirm.

2. On a spare machine (also tested on VM with same result), I run Ubuntu-Mate 17.10. Icon size seems too big here. When I click on the 3 dots as required, I see "Notification Area 1.18.4. However if i remove it from my panel, Steam and CloudStation indicators are still visible. The applet that brings indicators is "Indicator Applet Complete 1.18.0". I tried removing and re-adding it and I can confirm.

Note: Both my installations use default theme and default icons. Also per my previous message, cloudstation and steam icons are perfectly scaled on Ubuntu 17.10 and Kubuntu 17.10.
I hope this information is helpful, and I am available for more troubleshooting or testing if required.

Revision history for this message
Mauro Gaspari (ilvipero) wrote :

Attaching Screenshot from Ubuntu-Mate 17.10 showing both Steam and Cloudstation Indicators

Revision history for this message
Vlad Orlov (monsta) wrote :

Thanks, this confirms it's really mate-indicator-applet. I was also able to reproduce it with SpiderOak (see the link to UM community thread above).

Revision history for this message
Vlad Orlov (monsta) wrote :

Can reproduce with VLC too, provided that the current icon theme doesn't have a proper size icon for it. For example, mate-icon-theme-faenza has it, so it's not reproducible.

Can't reproduce with Mumble and Clementine at all. These apps don't want to make use of SNI in tray area and don't want to appear in the indicator applet.

Revision history for this message
Vlad Orlov (monsta) wrote :

Update: reproduced with Mumble and Clementine in 18.04.

tags: added: artful bionic
Revision history for this message
Abu Sakib (selectiveduplicate) wrote :

I can also confirm this; there are significant amount of posts on the community website. The default theme/s and Numix theme on UM both pose similar cropped-out icons:

https://ubuntu-mate.community/t/mate-18-04-inconsistent-icon-sizes/16859/13?u=apollonius
https://ubuntu-mate.community/t/vlc-icon-in-indicator-applet-complete/17086?u=apollonius

Revision history for this message
Karl Ljungkvist (k-ljungkvist) wrote :

I can reproduce this in Ubuntu Mate 18.04.1 LTS with the Synology Cloud Station application. The indicator applet just shows a huge icon, and never scales it when the panel is resized.

Revision history for this message
Mauro Gaspari (ilvipero) wrote :

I also can reproduce the original issue on Ubuntu Mate 18.10, with Synology Cloud Station. Synology Cloud Station icon is huge and will not scale. Indicator Applet Complete 1.20.1.
Same as previous report, this is not an issue on Gnome and KDE.

Norbert (nrbrtx)
Changed in mate-indicator-applet (Ubuntu):
status: Confirmed → Incomplete
Norbert (nrbrtx)
tags: removed: artful
Revision history for this message
Lucy Llewellyn (lucyllewy) wrote (last edit ):

Norbert, please don't mark issues as incomplete unless you state what information you think is missing.

tags: added: focal impish
Changed in mate-indicator-applet (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Norbert (nrbrtx) wrote :

Dani Llewellyn (diddledani) or anyone affected can you reproduce this bug on newest suppported Ubuntu MATE versions? With screenshot please.

Revision history for this message
Lucy Llewellyn (lucyllewy) wrote :

Yes. That's why I added the tags for focal and impish.

Revision history for this message
Lucy Llewellyn (lucyllewy) wrote :
Revision history for this message
Lucy Llewellyn (lucyllewy) wrote :
Revision history for this message
Lucy Llewellyn (lucyllewy) wrote :

This fixes the issue for me

see the built package for impish at: https://launchpad.net/~diddledani/+archive/ubuntu/mate-indicator-applet-1733301

Revision history for this message
Lucy Llewellyn (lucyllewy) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "patch to libayatana-indicator to correctly scale icons loaded by filename" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Mathew Hodson (mhodson)
Changed in mate-indicator-applet (Ubuntu):
importance: Undecided → Low
affects: ubuntu-mate → ubuntu
no longer affects: ubuntu
Revision history for this message
Brian Murray (brian-murray) wrote :

libayatana-indicator (0.8.4-2) unstable; urgency=medium

  [ Martin Wimpress ]
  * debian/patches:
    + Add 0001_scale-icons-when-loading-from-filename.patch (LP: #1733301)

  [ Mike Gabriel ]
  * debian/patches:
    + Fix file path in 0001_scale-icons-when-loading-from-filename.patch.

 -- Mike Gabriel <email address hidden> Tue, 19 Oct 2021 10:26:27 +0200

affects: mate-indicator-applet (Ubuntu) → libayatana-indicator (Ubuntu)
Changed in libayatana-indicator (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

I went ahead and uploaded this for Impish after making a few changes to the debdiff.

1) Fixed the package version number to 0.8.4-1ubuntu1
2) Fixed debian/control and XSBC-Original-Maintainer (using update-maintainer would have done this properly)
3) Removing unused patch tagging guideline info from that patch

This bug still needs SRU information added to the bug description for this to be accepted by the Ubuntu SRU team. See https://wiki.ubuntu.com/StableReleaseUpdates for details.

description: updated
description: updated
description: updated
Changed in libayatana-indicator (Ubuntu Impish):
status: New → Incomplete
importance: Undecided → Low
Revision history for this message
Lucy Llewellyn (lucyllewy) wrote (last edit ):

@seb128, please tell us what information is missing when you mark a bug as "incomplete" because without doing so it looks like you're just trying to trigger the automatic closure because you don't want to bother fixing a bug. (this is not an accusation, as @popey suggested - I'm merely trying to highlight why people might feel slighted when they've done the thing that was asked and still the bug is marked as incomplete with no helpful guidance as to what is missing)

Changed in libayatana-indicator (Ubuntu Impish):
status: Incomplete → Confirmed
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Mauro, or anyone else affected,

Accepted libayatana-indicator into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libayatana-indicator/0.8.4-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libayatana-indicator (Ubuntu Impish):
status: Confirmed → Fix Committed
tags: added: verification-needed verification-needed-impish
Revision history for this message
Lucy Llewellyn (lucyllewy) wrote (last edit ):

@Brian It looks like the change from version `build1ubuntu1` to `ubuntu1` has prevented the update to be recognised as an upgradable package. (The current version in the archive is `0.8.4-1build1`) That is unless I'm jumping the gun too quickly, and the package still needs to work its way through infrastructure to the repo (entirely plausible :-))

It looks like you made this change in your 1) above:

    1) Fixed the package version number to 0.8.4-1ubuntu1

Edit: yeah, I think I pulled the trigger too soon - it's not available in the -proposed repo yet :-)

Revision history for this message
Mauro Gaspari (ilvipero) wrote :

After installing Ubuntu MATE 21.10, fresh install on a virtual machine, I can see that clementine, vlc, steam icons seem to behave correctly out of the box. All icons seem to be properly scaled.
Version of indicator applet complete is 1.26.0

I installed per your request libayatana-indicator 0.8.4-1ubuntu1 and its dependencies, and restarted the VM. Still everything looks scaled well and without issues.

Revision history for this message
Lucy Llewellyn (lucyllewy) wrote :

Based on Mauro's report, and my own testing revealing no issues and showing that the initial reported problem is fixed by the package, I'm marking as verification-done.

tags: added: verification-done-impish
removed: verification-needed verification-needed-impish
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libayatana-indicator - 0.8.4-1ubuntu1

---------------
libayatana-indicator (0.8.4-1ubuntu1) impish; urgency=medium

  * Scale icons when loading from filename (LP: #1733301)

 -- Dani Llewellyn <email address hidden> Fri, 15 Oct 2021 10:22:28 +0100

Changed in libayatana-indicator (Ubuntu Impish):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for libayatana-indicator has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.