need backport the new scancode of dell-wmi for Microphone mute hotkey to xenial

Bug #1738153 reported by Alex Tu
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
Critical
Alex Tu
Xenial
Fix Released
Critical
Alex Tu
systemd (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Dimitri John Ledkov
Artful
Won't Fix
Undecided
Dimitri John Ledkov

Bug Description

[Impact]
dell-wmi expend the scan code of Microphone mute hotkey from 0x150 to 0x100150, so need to add a new mapping for it.

related commit:
https://github.com/systemd/systemd/pull/5012

[Test Case]
1. install the udev package which applied patch.
2. check if Microphone mute hotkey works.
3. if it not works, please provide the log of evtest.

[Regression Potential]
low regression potential, because it just add one more mapping.

also affect:
LP: #1736352
LP: #1740080
LP: #1734609

Alex Tu (alextu)
Changed in udev (Ubuntu):
assignee: nobody → Alex Tu (alextu)
description: updated
Alex Tu (alextu)
Changed in udev (Ubuntu):
status: New → Confirmed
Revision history for this message
Alex Tu (alextu) wrote :
Revision history for this message
Alex Tu (alextu) wrote :

and the deb packages could be get from ppa:alextu/test , systemd - 229-4ubuntu21oem1

Alex Tu (alextu)
Changed in udev (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

How critical is the fix? I'm asking because systemd is a big component triggering lots of autopkgtests, requiring a lot of shepherding for it to get to the archive (many tests fail and need to be retried etc.). Usually we bundle up a few fixes at once so that the time spent is worth the effort. For important fixes however we can consider getting this in as is.

What's the severity of the bug? How many users are affected and how does it impact them?

Revision history for this message
Alex Tu (alextu) wrote :

This issue happens to all xenial, zesty dell platform users who updated kernel to the one after 4.8.0. Because the root cause is the change of dell-wmi kernel module [1]

And this is a cert blocking issue for OEM projects.
How long will this kind SRU be in your experience ?

[1] https://github.com/torvalds/linux/commit/e075b3c898e4055ec62a1f0ed7f3b8e62814bfb6

Alex Tu (alextu)
Changed in udev (Ubuntu):
status: In Progress → Confirmed
Leon Liao (lihow731)
description: updated
description: updated
Mathew Hodson (mhodson)
Changed in udev (Ubuntu):
importance: Undecided → High
Revision history for this message
Simon Quigley (tsimonq2) wrote :

I'm resubscribing Łukasz Zemczak and unsubscribing ~ubuntu-sponsors for now because he's the last person to evaluate this as an SRU and there's nothing to sponsor quite yet.

Thanks!

Revision history for this message
Alex Tu (alextu) wrote :

looks this patch is missed in recently update[1],
as I said in #4, this issue will impact *all* user who updated their kernel.
The Microphone mute hotkey will be failed then.

[1] https://paste.ubuntu.com/p/NQMXTMzVbN/

Revision history for this message
Alex Tu (alextu) wrote :

btw,
it's already in bionic by this commit : https://github.com/systemd/systemd/pull/5012/commits/5d14ba02c4c2e09a9b158412a0912d0493e3b90f
And also checked systemd 237-3ubuntu4 in bionic included that patch.

the target of this launchpad ticket is to backport it to xenial.

Changed in udev (Ubuntu):
assignee: Alex Tu (alextu) → nobody
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Let me reach out to xnox to see if he's planning another systemd SRU after the current one migrates into -updates. If yes, maybe we can have him bundle up this change. If not, we can just release this one fix then.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Please do not assign bugs to udev source package, it has been long time merged into systemd source package.

Yeah, I can cherry-pick this for SRUs.

no longer affects: udev (Ubuntu)
no longer affects: udev (Ubuntu Xenial)
Changed in systemd (Ubuntu):
status: New → Fix Released
Changed in systemd (Ubuntu Xenial):
status: New → Confirmed
Changed in systemd (Ubuntu Artful):
status: New → Confirmed
Changed in systemd (Ubuntu Xenial):
assignee: nobody → Dimitri John Ledkov (xnox)
Changed in systemd (Ubuntu Artful):
assignee: nobody → Dimitri John Ledkov (xnox)
Changed in systemd (Ubuntu Artful):
status: Confirmed → Won't Fix
Changed in systemd (Ubuntu Xenial):
status: Confirmed → In Progress
Revision history for this message
Robie Basak (racb) wrote :

> low regression potential, because it just add one more mapping.

The patch uploaded also removes the old mapping. Is there any possibility that this will regress some users? How would one test for this?

Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Alex, or anyone else affected,

Accepted systemd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/229-4ubuntu21.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in systemd (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
cktenn (cktenn) wrote :

Verified fixed on DP/N BRM5-DVT1-C2H with xenial-proposed
Image: dell-bto-xenial-breckenridge-mlk-cfl-X46-20180705-128.iso

There's also one thing to mention; it has to reboot twice before the fix to take effect.

tags: added: verification-done-xenial
removed: verification-needed-xenial
Revision history for this message
Robie Basak (racb) wrote :

Please confirm the exact package version tested.

What about my question in comment 10? The Regression Potential currently says "it just add one more mapping" but this doesn't appear to be true because a mapping was also removed.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

@racb
unknown is a placeholder, which is now assigned to wlan. Without unknown, there would be debugging error kernel messages `unknown key pressed`. So previously we knew the physical key exists and is pressable, but dind't know what it should do, but now we do know what it does.

Revision history for this message
Robie Basak (racb) wrote :

Thanks. Out of band Dimitri explained to me that "unknown" isn't really a mapping, which I think is key.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package systemd - 229-4ubuntu21.5

---------------
systemd (229-4ubuntu21.5) xenial; urgency=medium

  [ Dimitri John Ledkov ]
  * systemctl: correctly proceed to immediate shutdown if scheduling fails
    (LP: #1670291)
  * hwdb: update micmute on Dell laptops. (LP: #1738153)
  * hwdb: Use wlan keycode for all Dell systems. (LP: #1762385)
  * units: Disable journald Watchdog (LP: #1773148)

  [ Mauricio Faria de Oliveira ]
  * core: Fix for service to enter the 'failed' state (rather than 'inactive') after it repeatedly fails restart.
    (LP: #1795658)

  [ Dimitri John Ledkov ]
  * Disable dh_installinit generation of tmpfiles for the systemd package.
    (LP: #1748147)

 -- Dimitri John Ledkov <email address hidden> Mon, 08 Oct 2018 16:10:42 +0100

Changed in systemd (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Update Released

The verification of the Stable Release Update for systemd has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.