Bazaar Subversion Plugin

"pull" should handle removal of bzr:ancestry property

Bug #174690 reported by Arek Korbik
20
Affects Status Importance Assigned to Milestone
Bazaar Subversion Plugin
Fix Released
Low
Jelmer Vernooij
Bazaar Subversion Plugin 0.4.11

Bug Description

fetch.py: RevisionBuildEditor.change_dir_prop() method doesn't handle case when bzr:ancestry:* property has been removed from subversion repository (passed argument 'value' is None).

(This can happen for example if you try to revert your very first 'bzr -> svn' commit from the svn repository and then pull the changes ;)

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I'm not sure though how it should handle this. It's not possible to change history in bzr and the ancestry of the revision you reverted doesn't suddenly change, so I guess the only thing we can do is raise a better error message.

This will be less of a problem once bzr-svn starts using revision properties.

Jelmer Vernooij (jelmer)
Changed in bzr-svn:
status: New → Confirmed
Revision history for this message
David Cournapeau (david-ar) wrote :

Does that mean that a repository with this problem cannot be imported at all with bzr-svn ?

Jelmer Vernooij (jelmer)
Changed in bzr-svn:
assignee: nobody → jelmer
importance: Undecided → Low
status: Confirmed → Triaged
Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 174690] Re: "pull" should handle removal of bzr:ancestry property

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Cournapeau wrote:
> Does that mean that a repository with this problem cannot be
> imported at all with bzr-svn ?
 Yes.

This can be fixed, but it would either make it impossible to reference
any of the revisions in the branch on which the property was removed
or it would severely (and I really mean severely) degrade performance
of bzr-svn.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQCVAwUBSCuYVAy0JeEGD2blAQJorQP/c25yJZxn6s+1ShLkb+3H5Cf98xrqXHi6
R80X17j/QmBBg+CDmHUKlkTgVBSIde7wmehg8BSGXRZNWFPEGPYSO+x7hq4kMS5u
gO9VC2VBaUxRSofTbVxweHWPkBCPGyv/I5il55s50bQM6s4pZpDMA2UEKDPWrugu
f5voVH/7L5Q=
=yHEk
-----END PGP SIGNATURE-----

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

bzr:ancestry is no longer used and we can cope with other properties being removed

Changed in bzr-svn:
status: Triaged → Fix Committed
Jelmer Vernooij (jelmer)
Changed in bzr-svn:
milestone: none → 0.4.11
Jelmer Vernooij (jelmer)
Changed in bzr-svn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.