tripleo

tripleo-ipsec : failure to set current IP fact

Bug #1749338 reported by Emilien Macchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Juan Antonio Osorio Robles
tripleo queens-rc1

Bug Description

https://logs.rdoproject.org/38/523638/32/openstack-check/gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset042-master-tht/Z095530f2472142498828832f6e760599/undercloud/home/jenkins/overcloud_deploy.log.txt.gz#_2018-02-13_16_38_49

2018-02-13 16:38:49 | TASK [tripleo-ipsec : Set current IP fact] *************************************
2018-02-13 16:38:49 | task path: /usr/share/ansible/roles/tripleo-ipsec/tasks/ipsec-conf.yml:17
2018-02-13 16:38:49 | META: noop
2018-02-13 16:38:49 | fatal: [192.168.24.11]: FAILED! => {"msg": "Error in jmespath.search in json_query filter plugin:\n'query' is undefined"}
2018-02-13 16:38:49 | fatal: [192.168.24.9]: FAILED! => {"msg": "Error in jmespath.search in json_query filter plugin:\n'query' is undefined"}
2018-02-13 16:38:49 | fatal: [192.168.24.10]: FAILED! => {"msg": "Error in jmespath.search in json_query filter plugin:\n'query' is undefined"}

It happens in all jobs.

Tags: ci
OpenStack Infra (hudson-openstack)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
Juan Antonio Osorio Robles (juan-osorio-robles) wrote :

This Revert fixes the issue https://review.openstack.org/#/c/544175/ . I'm trying to figure out what part of the original commit breaks the config-download/ipsec deployment and see if I can fix that. But in the meantime, at least we know where this error came from.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/544227

Revision history for this message
Juan Antonio Osorio Robles (juan-osorio-robles) wrote :

The actual commit that introduced the issue is this one https://review.openstack.org/#/c/544227/ . There is a potential fix though, which is https://review.openstack.org/544229 . still gotta test it.

Revision history for this message
Juan Antonio Osorio Robles (juan-osorio-robles) wrote :

This is how it was being persisted in /var/lib/mistral/<ID>/Controller/fast_forward_upgrade_tasks.yaml

  - command: tripleo-repos {{ cmd_args | join(' ') }}
    name: Enable tripleo-repos
    vars:
      cmd_args: '{{ fast_forward_repo_args | json_query(query) }}'
      query: tripleo_repos[?release=='{{release}}'].args

The variable definitions are dependent on each other, so query is undefined.

Revision history for this message
Juan Antonio Osorio Robles (juan-osorio-robles) wrote :

Sorry, the patch that introduced the issue was https://review.openstack.org/#/c/515429/ and https://review.openstack.org/#/c/544227/ is a revert to fix it.

https://review.openstack.org/544229 was an attempt to fix the issue but it didn't work out.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/544175
Reason: While this fixes the issue. it's not the root cause. This one is https://review.openstack.org/#/c/544227/ . Still trying to come up with a fix to avoid the revert though.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/544229
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d20264c8ba157668d434621eda1adb6980fb1ccc
Submitter: Zuul
Branch: master

commit d20264c8ba157668d434621eda1adb6980fb1ccc
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Feb 14 10:52:21 2018 +0100

    Do not depends on the order of the hash vars in ffu repo switching.

    As vars in defined as an hash and we can't depends on the ordering
    here.

    Change-Id: I93fb1811aff6a5c0e5f984f8562a6cdd207f1b5c
    Related-Bug: #1749338

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/544227

Juan Antonio Osorio Robles (juan-osorio-robles)
Changed in tripleo:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.