lcd-filter patch is using wrong parameters for FT_Library_SetLcdFilter

Bug #174934 reported by Sylvain Pasche
6
Affects Status Importance Assigned to Milestone
libcairo (Ubuntu)
Fix Released
Medium
Ubuntu Desktop Bugs
Nominated for Gutsy by Matti Lindell

Bug Description

Brandon Wright found an issue with the lcd-filter patch:

https://bugs.freedesktop.org/show_bug.cgi?id=10301#c21

quote:
". In fact, the original
Ubuntu-modified changeset to Cairo has a significant error where they use
FC_LCD_FILTER_* definitions where they should be using FT_LCD_FILTER_* to pass
to FT_Library_SetLcdFilter. I checked the headers, and the definitions don't
correspond. This leads me to believe that their changes never did what they
were supposed to in the first place."

Revision history for this message
Sylvain Pasche (sylvain-pasche) wrote :
Revision history for this message
Pedro Villavicencio (pedro) wrote :

To be looked by a desktop dev, thanks.

Changed in libcairo:
assignee: nobody → desktop-bugs
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, that will be fixed with the next upload

Changed in libcairo:
status: Triaged → Fix Committed
Revision history for this message
Sebastien Bacher (seb128) wrote :

That should be fixed in hardy now

 libcairo (1.5.4-0ubuntu1) hardy; urgency=low
 .
   * debian/rules:
     - updated shlibs version
 .
   [ Fabien Tassin ]
   * new upstream snapshot: 1.5.4
   * Drop patches no longer useful:
     - debian/patches/91_malloc-overflow-fixes.dpatch
     - debian/patches/90_from_git_fix_zero_sized_bitmap_handling.dpatch
     - debian/patches/90_from_git_fix_not_available_glyph_handling.dpatch
   * Replace Ubuntu's lcd patch by patch from Freedesktop bug #10301
     - drop debian/patches/02-cairo-1.4.8-lcd-filter-2.dpatch
     - add debian/patches/02-lcd_filter_freedesktop_bug10301.patch
   * Move from 16.16 to 24.8 fixed point precision
     - add debian/patches/01-fixed_point_24.8_precision.dpatch
   * Add libpixman-1-dev (>= 0.9.4) to Build-deps
     - update debian/control
   * Update debian/patches/00list

Changed in libcairo:
status: Fix Committed → Fix Released
Revision history for this message
Matti Lindell (mlind) wrote :

Would it be possible to get this fixed in Gutsy too ?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.