Web Client: Add Volumes - Cursor focus

Confirmed 3.1 -- seeing this when I use "add volumes & copies"

This bug is a major workflow problem for a library doing centralized cataloging for multiple branches. Updating the system generated barcode created in acquisitions to the real item barcode is no longer a simple scan the barcode when opening the item record. It now requires moving to the barcode box and highlighting the existing barcode, then scanning. Two steps when there used to be none.

Added tag regression as this was a function available in the xul client.

Bumping this up to Medium, because of the impact you were talking about, Janet.

I have been looking at this. Getting the cursor to always focus in the barcode fields is pretty simple. However, it jumps to the barcode field when editing existing copies, not just when adding new ones. Is that what everyone wants, or should it only autofocus the barcode field when adding a new copy?

Actually, focusing when the barcode is empty is pretty easy, too, so here's a branch (1 commit) that does that:

working/user/dyrcona/lp1752968-add-volumes-cursor-focus

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1752968-add-volumes-cursor-focus

I'm also targeting at 3.2 and 3.1 since this is considered a regression.

This bug was to keep the focus in the barcode box when editing items created during acquisitions, not adding new items. The current xul behavior has the cursor focus in the barcode box both when adding or editing items so I see that as the preferred behavior to keep the web client consistent with xul.

Janet, the bug description says nothing whatsoever about acquisitions. You mention it in comment #2, but I don't think this bug was originally about acquisitions.

Maybe Christine can clarify what she meant?

Hi Jason

Thank you! This bug was created for the cursor focus when adding new volumes & copies.

It would be ideal if the cursor could autofocus to barcode field when editing items as well (as Janet mentioned). (Assuming "Always display Volume/Copy Detail pane" is checked in default tab)

Re your comment in #5 I think we would want autofocus in the barcode field both when adding new and editing existing.

Thank you for your work on this!!

Thanks, Christine.

I have force-pushed a change over the previous commit to always focus the barcode field in the volume/copy editor.

My apologies. I was going to create a bug about cursor focus and acquisitions and this bug already existed so I added comment #2. Now I'll simply amend my comment #7 to agree with the original bug report, same cursor focus as xul.

This behavior is not the same as the xul client for editing (replacing) the barcode. In xul the focus means the barcode itself is highlighted so scanning in a barcode deletes what's in the box, replacing it with the new barcode. In the web client the cursor focus is in the box at the end of the barcode so scanning a new barcode adds it to the existing one.

The behavior seems fine when adding a new item as the cursor is at the beginning of the barcode.

OK, Janet, thanks for the feedback!

I have pushed another commit to the original branch that will select the text in the barcode box if there is any.

Tested Jason's new commit on 3.2. The cursor focus is now in the barcode box with an existing barcode highlighted so that scanning in a new barcode replaces the existing one.
I can sign off on this branch, Janet Schrader, <email address hidden>.

Thank you Jason!!

On 18/12/2018 7:47 a.m., Jason Stephenson wrote:
> OK, Janet, thanks for the feedback!
>
> I have pushed another commit to the original branch that will select the
> text in the barcode box if there is any.
>

Thank you Janet!

On 18/12/2018 8:25 a.m., Janet Schrader wrote:
> Tested Jason's new commit on 3.2. The cursor focus is now in the barcode box with an existing barcode highlighted so that scanning in a new barcode replaces the existing one.
> I can sign off on this branch, Janet Schrader, <email address hidden>.
>

Thanks, Janet!

I have rebased, added Janet's signoff, and pushed to a new working branch, user/dyrcona/lp1752968-add-volumes-cursor-focus_signoff

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1752968-add-volumes-cursor-focus_signoff

I want to add that we are using this branch in production at CW MARS since we upgraded to Evergreen 3.2.4 on April 15, 2019. I will very likely push the fix to master, rel_3_3, rel_3_2, and rel_3_1 very soon barring any negative feedback in the meantime.

Pushed to master and rel_3_1 through rel_3_3.

Thanks everyone for commenting and testing!