cat-revision gives backtrace when invalid revid is specified

Bug #175569 reported by Jelmer Vernooij
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Low
Jelmer Vernooij

Bug Description

  affects bzr

ganieda:~/bzr-rebase/debian% bzr cat-revision 2
bzr: ERROR: bzrlib.errors.NoSuchRevision:
KnitRevisionStore(VersionedFileStore('file:///data/jelmer/bzr-rebase/.bzr/repository/')) has no revision 2

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 802,
in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 758,
in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 492,
in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 768,
in ignore_pipe
    result = func(*args, **kwargs)
  File "/usr/lib/python2.4/site-packages/bzrlib/builtins.py", line 218,
in run

self.outf.write(b.repository.get_revision_xml(revision_id).decode('utf-8'))
  File "/usr/lib/python2.4/site-packages/bzrlib/decorators.py", line
127, in read_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.4/site-packages/bzrlib/repository.py", line
1024, in get_revision_xml
    rev = self.get_revision(revision_id)
  File "/usr/lib/python2.4/site-packages/bzrlib/decorators.py", line
127, in read_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.4/site-packages/bzrlib/repofmt/knitrepo.py",
line 177, in get_revision
    return self.get_revision_reconcile(revision_id)
  File "/usr/lib/python2.4/site-packages/bzrlib/decorators.py", line
127, in read_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.4/site-packages/bzrlib/repository.py", line
998, in get_revision_reconcile
    return self._get_revisions([revision_id])[0]
  File "/usr/lib/python2.4/site-packages/bzrlib/decorators.py", line
127, in read_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.4/site-packages/bzrlib/repository.py", line
1012, in _get_revisions
    self.get_transaction())
  File "/usr/lib/python2.4/site-packages/bzrlib/store/revision/knit.py",
line 88, in get_revisions
    texts = self._get_serialized_revisions(revision_ids, transaction)
  File "/usr/lib/python2.4/site-packages/bzrlib/store/revision/knit.py",
line 106, in _get_serialized_revisions
    raise errors.NoSuchRevision(self, e.revision_id)
NoSuchRevision:
KnitRevisionStore(VersionedFileStore('file:///data/jelmer/bzr-rebase/.bzr/repository/')) has no revision 2

bzr 1.0.0.candidate.2 on python 2.4.4.final.0 (linux2)
arguments: ['/usr/bin/bzr', 'cat-revision', '2']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'de_DE.UTF-8'
plugins:
  authors /home/jelmer/.bazaar/plugins/authors [unknown]
  builddeb /home/jelmer/.bazaar/plugins/builddeb
[0.92.0dev0]

bzrtools /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools [1.0.0]

cia /usr/lib/python2.4/site-packages/bzrlib/plugins/cia
[unknown]
  email /home/jelmer/.bazaar/plugins/email [unknown]
  git /home/jelmer/.bazaar/plugins/git [unknown]
  global_log /home/jelmer/.bazaar/plugins/global_log [unknown]

launchpad /usr/lib/python2.4/site-packages/bzrlib/plugins/launchpad [unknown]

multiparent /usr/lib/python2.4/site-packages/bzrlib/plugins/multiparent.pyc [unknown]
  pqm /home/jelmer/.bazaar/plugins/pqm [unknown]

rebase /usr/lib/python2.4/site-packages/bzrlib/plugins/rebase [0.3.0]
  stats /home/jelmer/.bazaar/plugins/stats [unknown]
  svn /home/jelmer/.bazaar/plugins/svn [0.4.6dev0]

** Please send this report to <email address hidden>
   with a description of what you were doing when the
   error occurred.

--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Jelmer Vernooij (jelmer)
Changed in bzr:
assignee: nobody → jelmer
status: New → Fix Committed
importance: Undecided → Low
Jelmer Vernooij (jelmer)
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.