Mahara

Fix link color in Primary School and Ocean themes for "Notifications"

Bug #1756154 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 18.04.0
18.04
Fix Released
High
Unassigned
Mahara 18.04.0
18.10
Fix Released
High
Liam
Mahara 18.10.0

Bug Description

When you have the Primary School or Ocean theme on your site, the navigation bar in the inbox (/module/multirecipientnotification/inbox.php) does not show the links in the nav bar in the correct colors. In Ocean it is only the active link that is a problem, in Primary School it is both Inbox and Sent.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Changed in mahara:
milestone: none → 18.04.0
Jaque (jaque777)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Jaque (jaque777) wrote :

On my local instance, I can not replicate the problem on either the Ocean or the primary school theme, the colors are working correctly.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

I can show you tomorrow, Jaque.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

This only seems to happen when you upgrade a site.

Revision history for this message
Robert Lyon (robertl-9) wrote :

I do notice for the 'ocean' theme there is this on the sass/utilities/ dir:

_custom-variables.scss:$arrow-color: $brand-primary;
_custom-variables.scss:$arrow-text-color: #fff;
_custom-variables.scss:$arrow-link-color: #fff;
_custom-variables.scss:$arrow-link-hover-color: $text-color;
_custom-variables.scss:$arrow-link-active-color: #20738f;
_custom-variables.scss:$arrow-link-background-color: #fff;

_bootstrap-variables.scss:$arrow-color: darken($brand-info, 10%);
_bootstrap-variables.scss:$arrow-text-color: #fff;
_bootstrap-variables.scss:$arrow-link-color: #fff;
_bootstrap-variables.scss:$arrow-link-hover-color: $arrow-color;
_bootstrap-variables.scss:$arrow-link-active-color: $arrow-color;

And it looks like some things are defined twice and with different values

--
In primary school theme

we have
_custom-variables.scss:$arrow-color: $brand-primary;
_custom-variables.scss:$arrow-text-color: #fff;
_custom-variables.scss:$arrow-link-color: #ca0238;
_custom-variables.scss:$arrow-link-hover-color: $text-color;
_custom-variables.scss:$arrow-link-active-color: $brand-primary;
_custom-variables.scss:$arrow-link-background-color: #fff;
_custom-variables.scss:$arrow-link-group-color: #799323;

and I notice _custom-variables.scss:$arrow-link-color: #ca0238; would give the 'Sent' button the red colour

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8682

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8682
Committed: https://git.mahara.org/mahara/mahara/commit/113faa354393da3480ddfaf2f3d46ea2abd15d52
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 113faa354393da3480ddfaf2f3d46ea2abd15d52
Author: Liam <email address hidden>
Date: Thu Mar 22 10:20:08 2018 +1300

Bug #1756154: Fix link color in Primary School and Ocean themes for "Notifications"

behatnotneeded

Change-Id: I674cb8242cc1c522195647da5be4002440beafb8

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8686

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8686
Committed: https://git.mahara.org/mahara/mahara/commit/e1ba168c6678116f543c4d72145a052c5140e35c
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit e1ba168c6678116f543c4d72145a052c5140e35c
Author: Liam <email address hidden>
Date: Thu Mar 22 10:20:08 2018 +1300

Bug #1756154: Fix link color in Primary School and Ocean themes for "Notifications"

behatnotneeded

Change-Id: I674cb8242cc1c522195647da5be4002440beafb8
(cherry picked from commit 113faa354393da3480ddfaf2f3d46ea2abd15d52)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8693

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8693
Committed: https://git.mahara.org/mahara/mahara/commit/57e9c6b1045bc843fa0bb5514e1b6d3e564138c5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 57e9c6b1045bc843fa0bb5514e1b6d3e564138c5
Author: Liam <email address hidden>
Date: Thu Mar 22 17:18:26 2018 +1300

Bug #1756154: Fix link color in Primary School and Ocean themes for "Notifications"

Made the notifications style the default style

behatnotneeded

Change-Id: I1da5f02918f75a6eb59cb059ff8f9941b78cc023

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8707

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8707
Committed: https://git.mahara.org/mahara/mahara/commit/52217820c93e0fad5f8bd8a8260b5c38030d6737
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 52217820c93e0fad5f8bd8a8260b5c38030d6737
Author: Liam <email address hidden>
Date: Thu Mar 22 17:18:26 2018 +1300

Bug #1756154: Fix link color in Primary School and Ocean themes for "Notifications"

Made the notifications style the default style

behatnotneeded

Change-Id: I1da5f02918f75a6eb59cb059ff8f9941b78cc023
(cherry picked from commit 57e9c6b1045bc843fa0bb5514e1b6d3e564138c5)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.