Mahara

Extra div field when comments are turned off on page or artefact details page

Bug #1758181 reported by Steven
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Sarah Kirby
Mahara 18.10.0

Bug Description

Environment tested: Master
Browser tested: MS Edge (Virtualbox)

===================
Manual Test Script
===================

1) user has a portfolio page with one resume field block that is set to retract on it
2) user views Page displayed
3) user clicks the details link just below the one resume field block
4) user is redirected to a page only showing the one resume field block

Actual result: Page is displayed with the one resume field block and is retracted.✔ Just under the block area is a very light grey background section on the page ✘

Expected result: Light grey background section should not be displayed because this artefact cannot have a comment.

NOTE:
- this also happens when you have a page that does not allow comments. (could be any page without comments)
- this is visible in themes that have a background for the comment area

Catalyst QA

Tags: front-end
Revision history for this message
Steven (stevens-q) wrote :
Kristina Hoeppner (kris-hoeppner)
summary: - resume details page displays extra div field
+ Artefact details page displays extra div field when comments are turned
+ off
Changed in mahara:
milestone: none → 18.10.0
importance: Undecided → Medium
status: New → Confirmed
summary: - Artefact details page displays extra div field when comments are turned
- off
+ Extra div field when comments are turned off on page or artefact details
+ page
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8774

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
assignee: nobody → Sarah Kirby (sarahkirby)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8857

Revision history for this message
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: MS Edge (Virtualbox)

===================
Manual Test Script
===================

1) user has a portfolio page with one resume field block that is set to retract on it
2) user views Page displayed
3) user clicks the details link just below the one resume field block
4) user is redirected to a page only showing the one resume field block
5) Page is displayed with the one resume field block and is retracted.✔

Actual result: There is no light grey background section displayed just under the block area as expected ✔

Catalyst QA Approved ✔

Revision history for this message
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome
===================
Manual Test Script
===================

Bug description: Regression - Content blocks with comment fields now display 2 comment fields and should only display 1 comment field (ie. Image block)

Preconditions:

1. User has portfolio page with the following blocks on it
 a. one resume field block (does not have comment field)
 b. Image block (has comment field)

Test Steps:

1. User logged in
2. user browse to
portfolio page (not in edit mode)
3. User click the details link below the resume block
4. Confirm user is redirected to the Resume Block page ✔
5. Confirm the page does not display any comment fields ✔
6. User browse back one page
User click the details link below the resume block
Confirm user is redirected to the Image page ✔
Confirm the page does display a comment field ✔
User browse back one page
User click the Add comment link below the resume block
Confirm user is redirected to the Image page ✔
Confirm the page does display a comment field ✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8857
Committed: https://git.mahara.org/mahara/mahara/commit/1bf98911e8639efbdcbff3de4868d47d0c3ec81d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1bf98911e8639efbdcbff3de4868d47d0c3ec81d
Author: Sarah Kirby <email address hidden>
Date: Wed Apr 4 16:30:51 2018 +1200

Bug 1758181: Hide comment-container div if comments

are not present or enabled

behatnotneeded

Change-Id: Ie47a4e8735a8cc4fb13640a6c991b8af0c32171c

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8984

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8984
Committed: https://git.mahara.org/mahara/mahara/commit/d278b69382c58edf9a853fafae66c4eb9f12849c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d278b69382c58edf9a853fafae66c4eb9f12849c
Author: Sarah Kirby <email address hidden>
Date: Mon Jul 2 09:57:20 2018 +1200

Bug 1758181: Hide background colour of comment

container div if comments are not present or enabled

behatnotneeded

Change-Id: I7fed5fb90c34fcf955fc8551dacf128792e68cd7

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.