HTML export still contains the 'details' /'add comment' links for blocks on the pages

Bug #1762845 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Lisa Seeto

Bug Description

But they do not work and shouldn't be there

Revision history for this message
Robert Lyon (robertl-9) wrote :
Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

The Details link should still be there as it should take you to the details page where you can see comments if any had been left as well as additional metadata.

The "Add comment" link though shouldn't be there.

Lisa Seeto (lisaseeto)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Lisa Seeto (lisaseeto)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10665

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10665
Committed: https://git.mahara.org/mahara/mahara/commit/4c567b3cf29e9044760bb30041569c2e885f7308
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4c567b3cf29e9044760bb30041569c2e885f7308
Author: Lisa Seeto <email address hidden>
Date: Wed Dec 11 12:20:14 2019 +1300

Bug 1762845: HTML export still contains the 'details' / 'add comment' links for blocks on the pages

- add in render_instance_export func for comment block
- remove non-export things in render_instance_export
- add check for export status when setting canedit var

behatnotneeded

Change-Id: I3f9ae3d82c0a69277e2e6e79404f73ad9d35e3ba
Signed-off-by: Lisa Seeto <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 20.04.0
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.