Mahara

"tablerenderer call updatecallback" js error in profileicons.php

Bug #1767882 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic
Mahara 18.10.0
17.04
Fix Released
Medium
Unassigned
Mahara 17.04.8
17.10
Fix Released
Medium
Unassigned
Mahara 17.10.5
18.04
Fix Released
Medium
Unassigned
Mahara 18.04.1

Bug Description

To replicate:
Go to User menu->Content->Profile Pictures
In the browser's console an error is displayed: tablerenderer call updatecallback

before mochikit removal, we had filter() function defined in Base.js. There's still a bit of code trying to use the function that doesn't exist in Mahara anymore

Mochikit was removed in 17.04 so it affects all the rest of the versions

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: New → In Progress
Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

https://reviews.mahara.org/#/c/8816/

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8816
Committed: https://git.mahara.org/mahara/mahara/commit/790e51d1f5014aae7978e21b0babed693406671f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 790e51d1f5014aae7978e21b0babed693406671f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 30 09:38:30 2018 +1200

Bug 1767882: Remove old udpdatecallback call in js

was making tablerenderer call updatecallback(
error

But the element that was updating was removed in 2009
commit 2319c04578165d1ecd2b14d4691daf691d968e39

behatnotneeded

Change-Id: Icbc4718e01b9348f4e244e8d83620d527b9fbff2

Robert Lyon (robertl-9)
Changed in mahara:
importance: Low → Medium
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8850

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8851

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8852

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8852
Committed: https://git.mahara.org/mahara/mahara/commit/5a46cdaf4177545178f40c3f870e2911620199aa
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 5a46cdaf4177545178f40c3f870e2911620199aa
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 30 09:38:30 2018 +1200

Bug 1767882: Remove old udpdatecallback call in js

was making tablerenderer call updatecallback(
error

But the element that was updating was removed in 2009
commit 2319c04578165d1ecd2b14d4691daf691d968e39

behatnotneeded

Change-Id: Icbc4718e01b9348f4e244e8d83620d527b9fbff2
(cherry picked from commit 790e51d1f5014aae7978e21b0babed693406671f)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8851
Committed: https://git.mahara.org/mahara/mahara/commit/13473848842c4ffdfb823e8984576d821d5237a1
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 13473848842c4ffdfb823e8984576d821d5237a1
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 30 09:38:30 2018 +1200

Bug 1767882: Remove old udpdatecallback call in js

was making tablerenderer call updatecallback(
error

But the element that was updating was removed in 2009
commit 2319c04578165d1ecd2b14d4691daf691d968e39

behatnotneeded

Change-Id: Icbc4718e01b9348f4e244e8d83620d527b9fbff2
(cherry picked from commit 790e51d1f5014aae7978e21b0babed693406671f)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8850
Committed: https://git.mahara.org/mahara/mahara/commit/272cd1f5118e2ce3b1b5b4d6bffa74cdb5b067b5
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 272cd1f5118e2ce3b1b5b4d6bffa74cdb5b067b5
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 30 09:38:30 2018 +1200

Bug 1767882: Remove old udpdatecallback call in js

was making tablerenderer call updatecallback(
error

But the element that was updating was removed in 2009
commit 2319c04578165d1ecd2b14d4691daf691d968e39

behatnotneeded

Change-Id: Icbc4718e01b9348f4e244e8d83620d527b9fbff2
(cherry picked from commit 790e51d1f5014aae7978e21b0babed693406671f)

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.