Include nfp driver in linux-modules

Bug #1768526 reported by Simon Horman
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Released
Medium
Seth Forshee
Bionic
Fix Released
Medium
Seth Forshee

Bug Description

SRU Justification:
------------------

[Impact]

 * Currently the driver for Netronome Agilio SmartNICs, nfp.ko, is included in linux-moudles-extra.
   An implication of this is that on minimal installs, where the linux-modules but not linux-modules-extra
   packages are available, the nfp.ko module cannot be installed. In particular this means the driver for
   any VFs of Netronome Agilio SmartNICs which have been made available to guests using PCI pass-through
   cannot be used by those guests if they have installed using Canonical cloud images, a likely scenario.

   In contrast the driver for the i40e is provided in the linux-modules package and thus guests can
   access their VFs in the scenario described above.

   Thus we do not believe it is unreasonable to request that nfp.ko be included in linux-modules rather
   than linux-modules-extras. And we believe that this warrants SRU inclusion as it is the difference between
   users-of guests being able to use Netronome Agilio SmartNICs and not be able to use them.

   This is a packaging update request and included no request to change the kernel source code,
   thus no backports are requred.

[Test Case]

 * Install system using Canonical cloud images

 * Observer that /lib/modules/*/kernel/drivers/net/ethernet/netronome/nfp/nfp.ko is missing;

 * If an Netronome Agilio SmartNIC device is present, via PCI pass-through or otherwise,
   that the nfp driver is not loaded and no netdevs are present for the Netronome Agilio SmartNIC.

[Regression Potential]

 * Any bugs present in the nfp.ko will now be exposted to guests. However as the same nfp.ko driver binary
   is already included in and available on installs that have access to linux-modules-extra, this does not
   seem an unreasonable burden.

[Other Info]

 * None

CVE References

description: updated
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1768526

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Revision history for this message
Jan Gutter (jangutter) wrote :
Jan Gutter (jangutter)
Changed in linux (Ubuntu):
status: Incomplete → Confirmed
Changed in linux (Ubuntu):
importance: Undecided → Medium
status: Confirmed → Triaged
Revision history for this message
Simon Horman (horms-netronome) wrote :

Hi,

I'm wondering if there is anything Netronome can do to assist with regards to this bug. Its very important to us.

Seth Forshee (sforshee)
Changed in linux (Ubuntu):
assignee: nobody → Seth Forshee (sforshee)
status: Triaged → In Progress
Changed in linux (Ubuntu Bionic):
assignee: nobody → Seth Forshee (sforshee)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Seth Forshee (sforshee) wrote :

Committed to unstable, patch sent for bionic.

https://lists.ubuntu.com/archives/kernel-team/2018-May/092526.html

Changed in linux (Ubuntu):
status: In Progress → Fix Committed
Stefan Bader (smb)
Changed in linux (Ubuntu Bionic):
status: In Progress → Fix Committed
Revision history for this message
Brad Figg (brad-figg) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-bionic' to 'verification-done-bionic'. If the problem still exists, change the tag 'verification-needed-bionic' to 'verification-failed-bionic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-bionic
Revision history for this message
Jan Gutter (jangutter) wrote :

Thanks! I've created a custom cloud-image using the following method, and verified that the proposed package has indeed moved the module out of -extras into the main package.

curl 'http://cloud-images.ubuntu.com/daily/server/bionic/current/bionic-server-cloudimg-amd64.img' -O

cat >bionic-proposed <<EOF
Package: *
Pin: release a=bionic-proposed
Pin-Priority: 400
EOF

cat >bionic-proposed.list <<EOF
deb http://archive.ubuntu.com/ubuntu/ bionic-proposed restricted main multiverse universe
EOF

LIBGUESTFS_BACKEND=direct virt-copy-in \
  -a bionic-server-cloudimg-amd64.img \
  bionic-proposed.list /etc/apt/sources.list.d/
LIBGUESTFS_BACKEND=direct virt-copy-in \
  -a bionic-server-cloudimg-amd64.img \
  bionic-proposed /etc/apt/preferences.d/
LIBGUESTFS_BACKEND=direct virt-customize -m 2048\
  -a bionic-server-cloudimg-amd64.img \
  --run-command 'apt-get update' \
  --run-command 'DEBIAN_FRONTEND=noninteractive apt-get --assume-yes install linux-image-generic/bionic-proposed' \
  --run-command 'apt-get --assume-yes purge linux-modules-extra-*'

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (11.4 KiB)

This bug was fixed in the package linux - 4.15.0-23.25

---------------
linux (4.15.0-23.25) bionic; urgency=medium

  * linux: 4.15.0-23.25 -proposed tracker (LP: #1772927)

  * arm64 SDEI support needs trampoline code for KPTI (LP: #1768630)
    - arm64: mmu: add the entry trampolines start/end section markers into
      sections.h
    - arm64: sdei: Add trampoline code for remapping the kernel

  * Some PCIe errors not surfaced through rasdaemon (LP: #1769730)
    - ACPI: APEI: handle PCIe AER errors in separate function
    - ACPI: APEI: call into AER handling regardless of severity

  * qla2xxx: Fix page fault at kmem_cache_alloc_node() (LP: #1770003)
    - scsi: qla2xxx: Fix session cleanup for N2N
    - scsi: qla2xxx: Remove unused argument from qlt_schedule_sess_for_deletion()
    - scsi: qla2xxx: Serialize session deletion by using work_lock
    - scsi: qla2xxx: Serialize session free in qlt_free_session_done
    - scsi: qla2xxx: Don't call dma_free_coherent with IRQ disabled.
    - scsi: qla2xxx: Fix warning in qla2x00_async_iocb_timeout()
    - scsi: qla2xxx: Prevent relogin trigger from sending too many commands
    - scsi: qla2xxx: Fix double free bug after firmware timeout
    - scsi: qla2xxx: Fixup locking for session deletion

  * Several hisi_sas bug fixes (LP: #1768974)
    - scsi: hisi_sas: dt-bindings: add an property of signal attenuation
    - scsi: hisi_sas: support the property of signal attenuation for v2 hw
    - scsi: hisi_sas: fix the issue of link rate inconsistency
    - scsi: hisi_sas: fix the issue of setting linkrate register
    - scsi: hisi_sas: increase timer expire of internal abort task
    - scsi: hisi_sas: remove unused variable hisi_sas_devices.running_req
    - scsi: hisi_sas: fix return value of hisi_sas_task_prep()
    - scsi: hisi_sas: Code cleanup and minor bug fixes

  * [bionic] machine stuck and bonding not working well when nvmet_rdma module
    is loaded (LP: #1764982)
    - nvmet-rdma: Don't flush system_wq by default during remove_one
    - nvme-rdma: Don't flush delete_wq by default during remove_one

  * Warnings/hang during error handling of SATA disks on SAS controller
    (LP: #1768971)
    - scsi: libsas: defer ata device eh commands to libata

  * Hotplugging a SATA disk into a SAS controller may cause crash (LP: #1768948)
    - ata: do not schedule hot plug if it is a sas host

  * ISST-LTE:pKVM:Ubuntu1804: rcu_sched self-detected stall on CPU follow by CPU
    ATTEMPT TO RE-ENTER FIRMWARE! (LP: #1767927)
    - powerpc/powernv: Handle unknown OPAL errors in opal_nvram_write()
    - powerpc/64s: return more carefully from sreset NMI
    - powerpc/64s: sreset panic if there is no debugger or crash dump handlers

  * fsnotify: Fix fsnotify_mark_connector race (LP: #1765564)
    - fsnotify: Fix fsnotify_mark_connector race

  * Hang on network interface removal in Xen virtual machine (LP: #1771620)
    - xen-netfront: Fix hang on device removal

  * HiSilicon HNS NIC names are truncated in /proc/interrupts (LP: #1765977)
    - net: hns: Avoid action name truncation

  * Ubuntu 18.04 kernel crashed while in degraded mode (LP: #1770849)
    - SAUCE: powerpc/perf: Fix memory allocation for...

Changed in linux (Ubuntu Bionic):
status: Fix Committed → Fix Released
Changed in linux (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.