[SRU] python-swauth package dropped but not removed

Bug #1772681 reported by Edward Hope-Morley
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Cloud Archive
Invalid
Undecided
Unassigned
Ocata
Fix Released
Undecided
Unassigned
Pike
Fix Released
Undecided
Unassigned
Queens
Fix Released
Undecided
Unassigned
swauth (Ubuntu)
Invalid
Undecided
Unassigned
Artful
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Undecided
Edward Hope-Morley

Bug Description

[Impact]
Upgrading from Xenial/Mitaka to a newer release such as Newton or beyond will break since the newer packages dropped python-swauth package but do not uninstall it resulting in an install conflict. This patch fixes this by ensuring the upgrade uninstalls python-swauth prior to installing new swauth.

[Test Case]
* boot Xenial host
* sudo apt install swauth
* sudo add-apt-repository -y cloud-archive:newton (or whichever we are testing)
* sudo apt update
* sudo apt install swauth (upgrade)

OR

* boot Bionic host
* sudo apt install swauth -ensure it installs cleanly

[Regression Potential]
None envisaged

--------

Versions greater than 1.0.4-0 have dropped the python-swauth package but do not remove it such that an upgrade breaks with error like:

Unpacking swauth (1.1.0-3~cloud0) over (1.0.4-0ubuntu1.16.04.1) ...
dpkg: error processing archive /var/cache/apt/archives/swauth_1.1.0-3~cloud0_all.deb (--unpack):
 trying to overwrite '/usr/lib/python2.7/dist-packages/swauth/__init__.py', which is also in package python-swauth 1.0.4-0ubuntu1.16.04.1
Processing triggers for libc-bin (2.23-0ubuntu10) ...
Processing triggers for man-db (2.7.5-1) ...
Processing triggers for shared-mime-info (1.5-2ubuntu0.1) ...
Processing triggers for sgml-base (1.26+nmu4ubuntu1) ...
Processing triggers for ureadahead (0.100.0-19) ...
Processing triggers for systemd (229-4ubuntu21.2) ...
Errors were encountered while processing:
 /var/cache/apt/archives/swauth_1.1.0-3~cloud0_all.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

If i remove python-swauth prior to upgrade it works just fine.

no longer affects: swauth
tags: added: sts sts-sru-needed
Revision history for this message
Edward Hope-Morley (hopem) wrote :

swauth-1.0.4 debian/control - https://paste.ubuntu.com/p/QMMP9kBWbN/
swauth-1.1.0 debian/control - https://paste.ubuntu.com/p/GfPBkFWPB2/

summary: python-swauth merged into swauth and swauth-doc package added

Revision history for this message
Dan Streetman (ddstreet) wrote :

it looks like between 1.0.x and 1.1.0, there was a fork or re-homing done, with the original being https://github.com/gholt/swauth and new being https://github.com/openstack/swauth

so i believe the 'new' swauth started at version 1.1.0 with no history from the previous project, which is probably why it didn't include a Replaces: python-swauth

Revision history for this message
Corey Bryant (corey.bryant) wrote : Re: [Bug 1772681] Re: python-swauth package dropped but not removed

On Tue, May 22, 2018 at 3:12 PM, Dan Streetman <email address hidden>
wrote:

> it looks like between 1.0.x and 1.1.0, there was a fork or re-homing
> done, with the original being https://github.com/gholt/swauth and new
> being https://github.com/openstack/swauth
>
> so i believe the 'new' swauth started at version 1.1.0 with no history
> from the previous project, which is probably why it didn't include a
> Replaces: python-swauth
>

Probably so. I think we'll need to add Breaks/Replaces in line with #6 here:
https://wiki.debian.org/PackageTransition

> --
> You received this bug notification because you are a member of Ubuntu
> OpenStack, which is subscribed to Ubuntu Cloud Archive.
> https://bugs.launchpad.net/bugs/1772681
>
> Title:
> python-swauth package dropped but not removed
>
> Status in Ubuntu Cloud Archive:
> New
> Status in Ubuntu Cloud Archive newton series:
> New
> Status in Ubuntu Cloud Archive ocata series:
> New
> Status in Ubuntu Cloud Archive pike series:
> New
> Status in Ubuntu Cloud Archive queens series:
> New
> Status in Ubuntu Cloud Archive rocky series:
> New
> Status in swauth package in Ubuntu:
> New
> Status in swauth source package in Bionic:
> New
>
> Bug description:
> Versions greater than 1.0.4-0 have dropped the python-swauth package
> but do not remove it such that an upgrade breaks with error like:
>
> Unpacking swauth (1.1.0-3~cloud0) over (1.0.4-0ubuntu1.16.04.1) ...
> dpkg: error processing archive /var/cache/apt/archives/swauth_1.1.0-3~cloud0_all.deb
> (--unpack):
> trying to overwrite '/usr/lib/python2.7/dist-packages/swauth/__init__.py',
> which is also in package python-swauth 1.0.4-0ubuntu1.16.04.1
> Processing triggers for libc-bin (2.23-0ubuntu10) ...
> Processing triggers for man-db (2.7.5-1) ...
> Processing triggers for shared-mime-info (1.5-2ubuntu0.1) ...
> Processing triggers for sgml-base (1.26+nmu4ubuntu1) ...
> Processing triggers for ureadahead (0.100.0-19) ...
> Processing triggers for systemd (229-4ubuntu21.2) ...
> Errors were encountered while processing:
> /var/cache/apt/archives/swauth_1.1.0-3~cloud0_all.deb
> E: Sub-process /usr/bin/dpkg returned an error code (1)
>
>
> If i remove python-swauth prior to upgrade it works just fine.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/cloud-archive/+bug/1772681/+subscriptions
>
> --
> Ubuntu-openstack-bugs mailing list
> <email address hidden>
> Modify settings or unsubscribe at: https://lists.ubuntu.com/
> mailman/listinfo/ubuntu-openstack-bugs
>

summary: - python-swauth package dropped but not removed
+ [SRU] python-swauth package dropped but not removed
Changed in swauth (Ubuntu Bionic):
assignee: nobody → Edward Hope-Morley (hopem)
Changed in swauth (Ubuntu Bionic):
status: New → In Progress
description: updated
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "lp1772681-bionic.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
no longer affects: cloud-archive/rocky
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Ed,

Thanks for the patches. I think you're going to wan to use the following (more details at [1], [2], and [3]):

Package: swauth
  ...
  Breaks:
    python-swauth (<< 1.1.0-1),
  Replaces:
    python-swauth (<< 1.1.0-1),

Package: python-swauth
Depends:
 swauth,
 ${misc:Depends},
Architecture: all
Priority: optional
Section: oldlibs
Description: transitional dummy package for python-swauth
 This transitional package to swauth is safe to remove.

[1] https://wiki.debian.org/PackageTransition
[2] https://www.debian.org/doc/debian-policy/#packages-which-break-other-packages-breaks
[3] https://wiki.debian.org/RenamingPackages

no longer affects: cloud-archive/newton
Revision history for this message
Edward Hope-Morley (hopem) wrote :
Revision history for this message
Edward Hope-Morley (hopem) wrote :
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Hi Corey, i've updated the patches. I've not specified a version for Breaks or Replaces since this package would conflict with any version.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

Marking Cosmic as invalid as a fix should not be required for Cosmic. python-swauth last existed in xenial and I think patching swauth to the next LTS is enough.

Changed in swauth (Ubuntu):
status: New → Invalid
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Thanks Ed. I'm going to upload and will add the dummy transitional package for python-swauth. That'll enable upgrades of python-swauth to continue to get the latest swauth bits without having to explicitly install it.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

Ok so turns out all of the above in comment #8 is required for a clean upgrade that results in: https://paste.ubuntu.com/p/KfRdCD4CqB/.

Testing with just Breaks/Replaces (without << version) removes python-swauth on upgrade from xenial->bionic. The same occurs with Breaks/Replaces (without << version) and the dummy python-swauth package defined. Once the << versions are added to the Breaks/Replaces the dummy transitional package properly remains after upgrade.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

I've uploaded new swauth package versions to the Bionic and Artful review queues. @sru-team, please note there are 2 in the review queue for Bionic. Please reject the older version and consider the newest one. I've also uploaded to Ocata-staging.

Revision history for this message
Corey Bryant (corey.bryant) wrote : Please test proposed package

Hello Edward, or anyone else affected,

Accepted swauth into ocata-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:ocata-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-ocata-needed to verification-ocata-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-ocata-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-ocata-needed
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Edward, or anyone else affected,

Accepted swauth into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/swauth/1.3.0-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in swauth (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Edward, or anyone else affected,

Accepted swauth into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/swauth/1.2.0-3ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in swauth (Ubuntu Artful):
status: New → Fix Committed
tags: added: verification-needed-artful
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Hello Edward, or anyone else affected,

Accepted swauth into queens-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:queens-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-queens-needed to verification-queens-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-queens-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-queens-needed
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Hello Edward, or anyone else affected,

Accepted swauth into pike-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:pike-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-pike-needed to verification-pike-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-pike-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-pike-needed
Revision history for this message
Edward Hope-Morley (hopem) wrote :

I've tested installing python-swauth from xenial-updates then add ocata-proprosed and installing swauth then dist-upgrading to Pike then Queens and all lgtm. I was not able to test Artful or Bionic though as the package does not appear to exist in artful-proposed or bionic-proposed (corecyb is checking this out).

tags: added: verification-ocata-done verification-pike-done verification-queens-done
removed: verification-ocata-needed verification-pike-needed verification-queens-needed
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Artful and Bionic proposed packages were stuck due to the transitional python-swauth still not accepted. Supposedly fixed now so waiting for builds to appear.

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Bionic tested and lgtm.

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Edward Hope-Morley (hopem) wrote :

And Artful tested and lgtm.

tags: added: verification-done verification-done-artful
removed: verification-needed verification-needed-artful
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Could we get more information about which packages were tested for bionic and artful and, best, what testing was performed as part of the verification?

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Hi @sil2100 sure thing. For Artful this is what I did https://pastebin.ubuntu.com/p/fbQsscGGVm/ and for Bionic I did https://pastebin.ubuntu.com/p/sMbp2cH9MC/. So basically I checked that the correct versions were available and tested installing both the swauth and dummy python-swauth packages to verify they don't conflict.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package swauth - 1.3.0-1ubuntu1

---------------
swauth (1.3.0-1ubuntu1) bionic; urgency=medium

  [ Edward Hope-Morley ]
  * d/control: Add Breaks and Replaces rules to ensure python-swauth package
    is removed on upgrade (LP: #1772681).

  [ Corey Bryant ]
  * d/control: Add transitional package for python-swauth to ensure upgrades
    of python-swauth retain transitional package that depends on swauth
    (LP: #1772681).

 -- Corey Bryant <email address hidden> Thu, 07 Jun 2018 13:36:20 -0400

Changed in swauth (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for swauth has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package swauth - 1.2.0-3ubuntu1

---------------
swauth (1.2.0-3ubuntu1) artful; urgency=medium

  [ Edward Hope-Morley ]
  * d/control: Add Breaks and Replaces rules to ensure python-swauth package
    is removed on upgrade (LP: #1772681).

  [ Corey Bryant ]
  * d/control: Add transitional package for python-swauth to ensure upgrades
    of python-swauth retain transitional package that depends on swauth
    (LP: #1772681).

 -- Corey Bryant <email address hidden> Thu, 07 Jun 2018 13:41:16 -0400

Changed in swauth (Ubuntu Artful):
status: Fix Committed → Fix Released
Revision history for this message
Corey Bryant (corey.bryant) wrote :

The verification of the Stable Release Update for swauth has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

This bug was fixed in the package swauth - 1.3.0-1ubuntu1~cloud0
---------------

 swauth (1.3.0-1ubuntu1~cloud0) xenial-queens; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 swauth (1.3.0-1ubuntu1) bionic; urgency=medium
 .
   [ Edward Hope-Morley ]
   * d/control: Add Breaks and Replaces rules to ensure python-swauth package
     is removed on upgrade (LP: #1772681).
 .
   [ Corey Bryant ]
   * d/control: Add transitional package for python-swauth to ensure upgrades
     of python-swauth retain transitional package that depends on swauth
     (LP: #1772681).

Changed in cloud-archive:
status: New → Invalid
Revision history for this message
Corey Bryant (corey.bryant) wrote :

The verification of the Stable Release Update for swauth has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

This bug was fixed in the package swauth - 1.2.0-3ubuntu1~cloud0
---------------

 swauth (1.2.0-3ubuntu1~cloud0) xenial-pike; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 swauth (1.2.0-3ubuntu1) artful; urgency=medium
 .
   [ Edward Hope-Morley ]
   * d/control: Add Breaks and Replaces rules to ensure python-swauth package
     is removed on upgrade (LP: #1772681).
 .
   [ Corey Bryant ]
   * d/control: Add transitional package for python-swauth to ensure upgrades
     of python-swauth retain transitional package that depends on swauth
     (LP: #1772681).

Revision history for this message
Corey Bryant (corey.bryant) wrote :

The verification of the Stable Release Update for swauth has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

This bug was fixed in the package swauth - 1.2.0-2+deb9u1ubuntu0.17.04.1~cloud1
---------------

 swauth (1.2.0-2+deb9u1ubuntu0.17.04.1~cloud1) xenial-ocata; urgency=medium
 .
   * d/control: Add Breaks/Replaces and transitional package for python-swauth
     to ensure upgrades of python-swauth transition to swauth and retain
     transitional package that depends on swauth (LP: #1772681).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.