Item Status - missing option to "Show in Catalogue"

added a new branch user/abellenir/lp1773434-show-in-catalog: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/abellenir/lp1773434-show-in-catalog

Tested in both Firefox and Chrome and it works perfectly. Signoff branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1773434-show-in-catalog-signoff

I have tested this fix and the "Show in Catalogue" option does appear in item status action menu.
It does seem to work, but when the tabs open they show the default skin with no web client wrapper (all staff client options are gone).

the tabs should open in the record summary opac view with web client wrapper.

similar issue on https://bugs.launchpad.net/evergreen/+bug/1538675

sorry, i misunderstood the original question and opened new OPAC tabs for each record instead of opening a new staff client tab opened to the OPAC view of the selected records. (subtle difference.) OPAC decorations are hidden if you're logged into the staff client, which is why the options were gone.

i updated the link in the branch to open new staff client windows for the record. change is in this branch: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/abellenir/lp1773434-show-in-catalog

note: the new link will always open records to the "OPAC View" tab, even if the user has specified a different tab (eg: "Holdings View") as their default. if the user's preferred default tab should shown instead, we can remove "/catalog" from the end of the link. bug 1724348 will be relevant if we want this.

bugs 1731272 and 1761276 are also related to opening records. the fix in 1731272 was helpful for me.

Working branch user/jeffdavis/lp1773434-show-in-catalog-signoff has a signoff for the second commit in addition to gcollum's signoff for the first commit:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1773434-show-in-catalog-signoff

I'm targeting this to the next 3.1 release on the assumption that the missing functionality is an oversight and therefore a bug, rather than being a new feature.

Thanks Jeff! This works well. I also agree that it can be backported.

Do you think it would make sense to add this with the actions that are part of the "Show" group rather than adding them with the items at the top of the actions list?

Confirmed working. In the interest of getting this change into 3.2, I'll leave the question of menu reorganization for another bug.

Pushed to master and rel_3_1. Thanks, all!