Mahara

Third-level navigation in sub theme starter kit doesn't have background

Bug #1773853 reported by Kristina Hoeppner
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Jaque
Mahara 18.10.0

Bug Description

The third-level navigation bar is used in the following places:
- Group navigation
- Inbox navigation
- Resume navigation

Normally, it has a background color so that the title of the section is tied in with the individual navigation items. This is not the case for the sub theme starter kit.

It would be good to have a value set for that navigation bar. The raw theme has a value for it, maybe this can be adapted for the sub theme starter?

Attached is an image that shows the sub theme starter on the left and the raw theme on the right.

Tags: front-end
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Jaque (jaque777)
Changed in mahara:
assignee: nobody → Jaque (jaque777)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9016

Revision history for this message
Jaque (jaque777) wrote :

As the lighten and darken functions are used to create color shades from the theme-primary-color variable, not all color will produce a valid color shade. If an invalid shade is returned it falls back to the raw theme default background color which is white.

Care should be exercised when choosing a theme-primary-color for child themes created from the subthemestarter theme.

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9045

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9047

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9048

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9045
Committed: https://git.mahara.org/mahara/mahara/commit/dd03f06491760be81c01e9ee1a39107b49d4b387
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit dd03f06491760be81c01e9ee1a39107b49d4b387
Author: Jaque <email address hidden>
Date: Sun Aug 5 13:22:42 2018 +1200

Bug 1773853: Replace all lighten darken with more robust scale-color

behatnotneeded

Change-Id: I8a064a94a2aee874fe9fe19b506590296632fa94

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.