Mahara

Upgrade 3rd party plugin simpleSAMLphp for php 7.2

Bug #1774106 reported by Rebecca Blundell on 2018-05-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Fix Released	High	Rebecca Blundell	Mahara 18.10.0

Bug Description

related to https://bugs.launchpad.net/mahara/+bug/1752743

Our current version of simpleSAMLphp has the deprecated function create_function.
I'm not sure which version we are running, but I've checked the source code on the latest Github version which has updated this.

https://simplesamlphp.org/download
https://github.com/simplesamlphp/simplesamlphp

Kristina Hoeppner (kris-hoeppner) on 2018-05-30

Changed in mahara:
milestone:	none → 18.10.0
importance:	Undecided → High
status:	New → Confirmed

Rebecca Blundell (rjb-dev) on 2018-07-30

Changed in mahara:
assignee:	nobody → Rebecca Blundell (rjb-dev)

Revision history for this message

Rebecca Blundell (rjb-dev) wrote on 2018-07-30:

Using assert() with a string argument is also deprecated in php 7.2

There is a patch for SimpleSAMLphp which fixes this, but it has yet to be merged into a stable version.

https://github.com/simplesamlphp/simplesamlphp/issues/573

Kristina Hoeppner (kris-hoeppner) on 2018-08-01

Changed in mahara:
status:	Confirmed → In Progress

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-08-03: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9042

Revision history for this message

Kristina Hoeppner (kris-hoeppner) wrote on 2018-08-30:

We are waiting for SimpleSAMLphp 1.16.0 to be released.

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-09-26: A change has been merged

Reviewed: https://reviews.mahara.org/9042
Committed: https://git.mahara.org/mahara/mahara/commit/d2bab9b8116e0122a43b115743d50152958b107c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d2bab9b8116e0122a43b115743d50152958b107c
Author: Rebecca Blundell <email address hidden>
Date: Fri Aug 3 14:35:39 2018 +1200

Bug 1774106: Upgrade SAML for PHP 7.2

The issue is that assert() with a string arg is deprecated.
The patch that fixes this is currently a release candidate,
which I have installed here to see if the patch works.

Requiring people to use memcached, not memcache
Removed checks for mcrypt, no longer required

@TODO:
Replace RC version with release version when it comes out.

behatnotneeded

Change-Id: I111b8cedeb3847ce585ebac0eb576107542a93a2

Robert Lyon (robertl-9) on 2018-09-26