UnicodeDecodeError when mailing git review comment
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Colin Watson |
Bug Description
I reviewed https:/
UnicodeDecode
Traceback (most recent call last):
Module lazr.jobrunner.
self.
Module lp.services.
super(
Module lazr.jobrunner.
job.run()
Module lp.code.
mailer = CodeReviewComme
Module lp.code.
code_
Module lp.code.
self.
Module lp.code.
inline_
Module lp.code.
hunk_
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 33: ordinal not in range(128)
Looks similar to bug #1319124 but that one's fixed.
Related branches
- William Grant: Approve (code)
-
Diff: 35 lines (+4/-3)2 files modifiedlib/lp/code/mail/codereviewcomment.py (+2/-1)
lib/lp/code/mail/tests/test_codereviewcomment.py (+2/-2)
tags: | added: code-review email inline-comments lp-code oops |
Changed in launchpad: | |
status: | New → In Progress |
importance: | Undecided → Critical |
assignee: | nobody → Colin Watson (cjwatson) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Fixed in stable r18754 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 18754>.