Keyboard calculator button not working

Bug #1796499 reported by Efthimios Chaskaris
56
This bug affects 11 people
Affects Status Importance Assigned to Milestone
gnome-settings-daemon (Ubuntu)
Fix Released
Low
Unassigned
Cosmic
Fix Released
Low
Unassigned

Bug Description

* Impact
The calculator keybinding doesn't work with the gnome-calculator snap

* Test case
- go to gnome-control-center, keyboard and configure a keybinding to start the calculator (or use the default one which is the calculator key if you have a keyboard including one of those)
- install gnome-calculator as a snap and remove the deb (should be the case on the default installation)
- press the configured key

-> the calculator should start

* Regression potential
The code allows trying 2 .desktop name, upstream renamed their in the 3.23 which was in zesty, they still include the fallback but Ubuntu hasn't been needed it since zesty, the patch changes to know about the current .deb name and about the snap one. If users had pinned an years old version of the calculator then their keybinding is going to stop working

Revision history for this message
Efthimios Chaskaris (echaskaris) wrote :
description: updated
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, that's because the snap .desktop is named gnome-calculator_gnome-calculator.desktop which is different from what g-s-d is trying to use

affects: gnome-calculator (Ubuntu) → gnome-settings-daemon (Ubuntu)
Changed in gnome-settings-daemon (Ubuntu):
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Efthimios Chaskaris (echaskaris) wrote :

seb128 I don't understand what that means, but I am certain a solution is being worked on. I think the importance should be higher. As Flatron commented in the askubuntu question, "How could they possible break the Calculator ? Of all things that may be broken this one should always work on any OS, no matter what... Imagine being a new person to (Ubuntu) Linux and finding that your calculator simply does not work with no error".

Revision history for this message
Steve Langasek (vorlon) wrote :

Seb, this is missing an SRU template, including a discussion of regression-potential. I see that your patch is replacing the reference to gnome-calculator.desktop with gnome-calculator_gnome-calculator.desktop rather than supporting both, so if the user still has the deb installed, won't this regress for those users? (Presumably users of a flavor other than Ubuntu Desktop)

Changed in gnome-settings-daemon (Ubuntu):
status: In Progress → Incomplete
description: updated
Changed in gnome-settings-daemon (Ubuntu):
status: Incomplete → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Efthimios, or anyone else affected,

Accepted gnome-settings-daemon into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-settings-daemon/3.30.1.2-1ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-settings-daemon (Ubuntu Cosmic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-cosmic
Revision history for this message
Efthimios Chaskaris (echaskaris) wrote :

It's fixed. I'm using gnome-settings-daemon 3.30.1.2-1ubuntu3.

tags: added: verification-done verification-done-cosmic
removed: verification-needed verification-needed-cosmic
Mathew Hodson (mhodson)
Changed in gnome-settings-daemon (Ubuntu Cosmic):
importance: Undecided → Low
Revision history for this message
Sebastien Bacher (seb128) wrote :
Changed in gnome-settings-daemon (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Apparently the SRU FTBFS on arm64 and armhf (it was succeeding there previously). Could someone take a look?

https://launchpad.net/ubuntu/+source/gnome-settings-daemon/3.30.1.2-1ubuntu3

Revision history for this message
Arthur Blair (adblair) wrote :

Is this fix going to be applied in 18.04?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 3.30.1.2-1ubuntu3

---------------
gnome-settings-daemon (3.30.1.2-1ubuntu3) cosmic; urgency=medium

  * debian/patches/ubuntu_calculator_snap.patch:
    - teach gsd about the gnome-calculator snap .desktop name, so it knows
      how to start the calculator from its keybinding (lp: #1796499)

 -- Sebastien Bacher <email address hidden> Thu, 25 Oct 2018 13:56:39 +0200

Changed in gnome-settings-daemon (Ubuntu Cosmic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-settings-daemon has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.