release upgrader has no icon in gnome-shell dock

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
http://iso.qa.ubuntu.com/qatracker/reports/bugs/1797384

Do you think reusing update-manager's icon would be okay?

for the record:

11/10 19:10:14 <bdmurray> Laney: Did you see my comment on bug 1797384?
11/10 19:10:14 <ubottu> bug 1797384 in ubuntu-release-upgrader (Ubuntu) "release upgrader has no icon in gnome-shell dock" [Undecided,New] https://launchpad.net/bugs/1797384
11/10 20:02:05 <Laney> bdmurray: no, but yes that'd probably be fine :-)

ubuntu-release-upgrader actually uses multiple dialogs and some of them are in the dist-upgrader and some of them are from the ubuntu-release-upgrader install on the system, so to fix this everywhere will require u-r-u updates in cosmic and disco. The SRU should also be done in Ubuntu 18.04 since it is an LTS.

This bug was fixed in the package ubuntu-release-upgrader - 1:19.04.4

---------------
ubuntu-release-upgrader (1:19.04.4) disco; urgency=medium

  * Set icon_name in the dialogs so that there will be an icon in gnome-shell.
    (LP: #1797384)

 -- Brian Murray <email address hidden> Wed, 07 Nov 2018 15:55:25 -0800

Verifying this on bionic is dependent on using the -p switch with do-release-upgrade / check-new-release-gtk or waiting until the cosmic SRU is in -updates.

Hello Iain, or anyone else affected,

Accepted ubuntu-release-upgrader into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:18.10.11.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

This was accepted to bionic too, but the tool ran into a locking issue and didn't comment. Go forth and verify both.

I tested the release upgrade process from Cosmic to Disco and confirm that there are no icons throughout all stages of the upgrade process screenshots attached.

Release notes screen for disco.

Screenshot from when the dist-upgrader tarball was being run.

I tested the upgrade process from Bionic to Cosmic and confirm that there are icons through all stages of the upgrade process, screenshots attached.

And in comment #11 I meant that there "are now icons".

Release notes.

I had to run /usr/lib/ubuntu-release-upgrader/check-new-release-gtk with -d to be able able to see the icons when running the cosmic dist-upgrader tarball. This was expected though.

This bug was fixed in the package ubuntu-release-upgrader - 1:18.10.11.2

---------------
ubuntu-release-upgrader (1:18.10.11.2) cosmic; urgency=medium

  * Set icon_name in the dialogs so that there will be an icon in gnome-shell.
    (LP: #1797384)

 -- Brian Murray <email address hidden> Mon, 12 Nov 2018 13:04:53 -0800

The verification of the Stable Release Update for ubuntu-release-upgrader has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package ubuntu-release-upgrader - 1:18.04.29

---------------
ubuntu-release-upgrader (1:18.04.29) bionic; urgency=medium

  * Set icon_name in the dialogs so that there will be an icon in gnome-shell.
    (LP: #1797384)

 -- Brian Murray <email address hidden> Mon, 12 Nov 2018 13:09:05 -0800