multiple-nic sample template only add routes to External and Tenant interface

Bug #1801916 reported by Harald Jensås
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Harald Jensås

Bug Description

Routes where only added to the External and Tenant interface.

File: network/config/multiple-nics/role.role.j2.yaml

#######
### Condition to do below for non External|Tenant net.
#######
{%- if network.name not in ["External", "Tenant"] %}
  {%- if network.name in role.networks %}
              - type: interface
                name: nic{{loop.index + 1}}
                use_dhcp: false
                addresses:
                - ip_netmask:
                    get_param: {{network.name}}IpSubnet
  {%- endif %}
########
## elif ...
########
{%- elif network.name in role.networks or role.name == 'Networker' or role.name == 'ComputeDVR' %}
              - type: ovs_bridge
  {%- if network.name == "External" %}
                name: bridge_name
  {%- else %}
                name: br-{{network.name_lower}}
  {%- endif %}
                use_dhcp: false
  {%- if network.name in role.networks %}
                addresses:
                - ip_netmask:
                    get_param: {{network.name}}IpSubnet
  {%- endif %}
#######
### Routes added here
#######
                routes:
                    list_concat_unique:
                      - get_param: {{network.name}}InterfaceRoutes
  {%- if network.name in role.default_route_networks %}
                      - - default: true
                          next_hop:
                            get_param: {{network.name}}InterfaceDefaultRoute
  {%- endif %}
                members:
                - type: interface
                  name: nic{{loop.index + 1}}
                  use_dhcp: false
                  primary: true
#######
## endif
#######
{%- endif %}

The routes should be added in the first section prior to the 'elif' to ensure the other (non External|Internal) network interfaces get's the correct routes configured.

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
Harald Jensås (harald-jensas) wrote :
description: updated
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/613683
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=dc2bec100f5a354e2966090fd794cd111835b5ee
Submitter: Zuul
Branch: master

commit dc2bec100f5a354e2966090fd794cd111835b5ee
Author: Harald Jensås <email address hidden>
Date: Fri Oct 26 22:25:37 2018 +0200

    Fix multiple-nic sample template

    Routes where only added to the External and Tenant interface.
    This adds the routes also in the section setting up the nets
    that are not External or Tenant

    Closes-Bug: #1801916
    Change-Id: Iec55e0c4ba27dc9a0003693850301804355433cc

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/617108

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 10.2.0

This issue was fixed in the openstack/tripleo-heat-templates 10.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.openstack.org/617108
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=39ed1ecaa3a8b52456d8a9f4132ee193f0cfa490
Submitter: Zuul
Branch: stable/rocky

commit 39ed1ecaa3a8b52456d8a9f4132ee193f0cfa490
Author: Harald Jensås <email address hidden>
Date: Fri Oct 26 22:25:37 2018 +0200

    Fix multiple-nic sample template

    Routes where only added to the External and Tenant interface.
    This adds the routes also in the section setting up the nets
    that are not External or Tenant

    Closes-Bug: #1801916
    Change-Id: Iec55e0c4ba27dc9a0003693850301804355433cc
    (cherry picked from commit dc2bec100f5a354e2966090fd794cd111835b5ee)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.2.0

This issue was fixed in the openstack/tripleo-heat-templates 9.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.