Evergreen

Password Reset results in Internal Server Error

Bug #1804038 reported by Jason Boyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
Evergreen 3.3-beta1
3.1
Fix Released
High
Unassigned
Evergreen 3.1.12
3.2
Fix Released
Undecided
Unassigned
Evergreen 3.2.2

Bug Description

Eg 3.2

The changes to Actor.pm in bug 1552778 appears to have broken the 2 uses of clense_ISO8601 (used for password reset) that are in that module. Specifying the full module path (OpenSRF::Utils::clense_ISO8601) should correct it.

Jason Boyer (jboyer)
Changed in evergreen:
importance: Undecided → High
Kathy Lussier (klussier)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jason Boyer (jboyer) wrote :

This branch fixes all 3 undecorated calls to clense_ISO8601 that I found in a cursory search. http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1772062_clense_iso8601 working/user/jboyer/lp1772062_clense_iso8601

To test:
enable password resets
try to perform one, get an Internal Server Error page.
Apply patch
try to perform a password reset, arrive at "it's on its way!" page.

tags: added: pullrequest
Revision history for this message
Jason Boyer (jboyer) wrote :

Quick note to testers/committers, that is the correct branch to address this bug; I just mis-named it because I had too many LP tabs open apparently.

Revision history for this message
Dan Wells (dbw2) wrote :

After some chatting in IRC, a new potential branch is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1804038_fix_old_datetime_function_calls

working/user/dbwells/lp1804038_fix_old_datetime_function_calls

Instead of forcing these through the now defunct OpenSRF versions, let's have them use the new and shiny OpenILS versions.

Revision history for this message
Jason Boyer (jboyer) wrote :

And I prefer doing things the right way, so after testing Dans' branch everything looks good. Signoff lives here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1804038_iso8601_signoff / working/user/jboyer/lp1804038_iso8601_signoff

Dan Wells (dbw2)
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Jason Boyer (jboyer)
tags: added: signedoff
Revision history for this message
Dan Wells (dbw2) wrote :

Pushed to master and rel_3_2. Thanks, Jason!

Also, targeting to 3.1 as another potential tack-on to the WIP for that version.

Changed in evergreen:
status: Confirmed → Fix Committed
milestone: none → 3.3-beta1
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
status: Fix Committed → Fix Released
Dan Wells (dbw2)
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Revision history for this message
Dan Wells (dbw2) wrote :

Dependent bug #1552778 has now been merged to 3.1, so merging this as well.

Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.