Falcon crashes when Source package changes after installing

Bug #180724 reported by Raphaël Doursenaud
2
Affects Status Importance Assigned to Milestone
Falcon
Fix Released
Undecided
Unassigned

Bug Description

Each time the dsc file changes here's what happens :

$ falcon scan
Falcon repository manager 2.0.1 (C)2005-2008 Dennis Kaarsemaker <email address hidden>
* Scanning component 'gutsy/main'
W: Source package ardour_2.1+svn2830-ematech1.dsc changed after installing

 === ERROR! ===

An error occured in falcon. This is probably a bug in the software.
Please file a bug at https://launchpad.net/falcon/+filebug and
include the following backtrace:

Traceback (most recent call last):
  File "/usr/bin/falcon", line 235, in ?
    component.scan(clean = action=='clean')
  File "/usr/lib/python2.4/site-packages/falcon/plugin.py", line 155, in wrapped_func
    result = func(*args, **kwargs)
  File "/usr/lib/python2.4/site-packages/falcon/pocket.py", line 184, in scan
    newfiles = s.rescan()
  File "/usr/lib/python2.4/site-packages/falcon/package.py", line 189, in rescan
    self.packagename = controlfields['source']

I workaround this by clearing the "falcon_sourcepackage" table in the sqlite3 database.

Related branches

Revision history for this message
Dennis Kaarsemaker (dennis) wrote :

you missed the most important part of the backtrace: the actual error :)

Revision history for this message
Dennis Kaarsemaker (dennis) wrote :

I think I found the bug though, there was a comma that shouldn't be there, please test with falcon 2.0.2, which will be released later today.

Revision history for this message
Raphaël Doursenaud (rdoursenaud) wrote :

Whoops. You're right!
The error was :

NameError: global name 'controlfields' is not defined

I'll test your fix as soon as I can, thanks!

Revision history for this message
Dennis Kaarsemaker (dennis) wrote :

The fix didn't work and fixing it properly uncovered another bug. I'm debugging that now.

Revision history for this message
Dennis Kaarsemaker (dennis) wrote :

A whole mess wass uncovered (a part that was never properly ported to the falcon 2.0 architecture), I rewrote the rescanning logic and it works fine now. Tested with your ardour package and another small one.

Revision history for this message
Raphaël Doursenaud (rdoursenaud) wrote :

Fixed for me in the 2.0.2 release. Thanks a lot!

Revision history for this message
Dennis Kaarsemaker (dennis) wrote :

Thanks for testing! If you ever need to reinitalize your repo or create a new one, please upgrade to 2.0.3, 2.0.2 and prior have a nasty bug with initial setup which you won't see on existing repositories.

Changed in falcon:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.