Evergreen

Use TRUNCATE, not DELETE which refreshing reporter.materialized_simple_record

Bug #1811689 reported by Chris Sharp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 3.3.0

Bug Description

In this commit: http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=85efd3b40bc3d53d7d004b8bd02a89bd7ceeaa1f , the original TRUNCATE behavior of the reporter.enable_materialized_simple_record_trigger function was changed to accommodate libraries using Slony-I database replication. Since most if not all Evergreen instances are using built-in PostgreSQL replication, we should be using TRUNCATE again in the interest of efficiency.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

I want to add that Jason Boyer mentioned in IRC that modern Slony now handles TRUNCATE properly:

http://irc.evergreen-ils.org/evergreen/2019-01-11#i_390434

Revision history for this message
Bill Erickson (berick) wrote :

Fix pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1811689-rmsr-truncate

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
milestone: none → 3.3-beta1
status: New → Confirmed
importance: Undecided → Medium
tags: added: pullrequest
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

Worked for me. Sign off pushed to user/rogan/lp1811689

tags: added: signedoff
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Rogan. Merged to master.

I have opted not to back-port to 3.1 or 3.2 since it's not really bug, or not a very serious one anyway, and back-porting DB updates adds upgrade complication.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.