Big samba memory leak fixed upstream

Thank you for your bug report, according to the upstream discussion the issue was create by that commit
https://github.com/samba-team/samba/commit/bd9285b1 and looks like a good candidate for a bionic SRU, it shouldn't apply/be an issue on trusty though which has 4.1/4.3 samba series

On top of the original Samba bug report (https://bugzilla.samba.org/show_bug.cgi?id=13372) it says this affects *Samba 4.1 and newer* or am I interpreting it incorrectly ?

At least I am experiencing the same behavior on Ubuntu 14.04.5 Server with Samba 4.3.11. Sad if it won't help us with our problem.

The offending code was submitted to Samba at 29th Jun 2017, you can find the commit here: https://gitlab.com/samba-team/samba/commit/bd9285b19741128bae501b721d9e63dd9a9bd833 If you search for the source file name: source3/modules/vfs_default.c on the page.

Maybe the date when the bug appeared sheds some light which releases really are affected.

Ok, I see that you already found the date information :)

"4.1 and newer" is only what their bugzilla has register as product, the list is
https://bugzilla.samba.org/describecomponents.cgi

they seem to use it to classify bugs that impact "not too ancien" samba versions, it doesn't mean 4.1 is impacted

(so yeah, it's not likely to be the same issue you are having on trusty)

Fixed in cosmic and later.

I'm not sure this is robust enough as a test case, that's why I'm adding it here instead of in the test caseh, but I ran smbd under valgrind before and after the update, and less bytes were lost for the same smbclient connection:

before:
==3977== LEAK SUMMARY:
==3977== definitely lost: 72 bytes in 7 blocks

After:
==5438== LEAK SUMMARY:
==5438== definitely lost: 24 bytes in 1 blocks

The client command was (with a suitable smb.conf and /pub directory):
smbclient //localhost/pub -U ubuntu%ubuntu -c "pwd;dir;cd dir1;dir;pwd;cd dir11; pwd; dir; cd /; cd dir2; pwd; dir; cd /"

Hello Mikael, or anyone else affected,

Accepted samba into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/samba/2:4.7.6+dfsg~ubuntu-0ubuntu2.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

With the bionic packages:

 *** 2:4.7.6+dfsg~ubuntu-0ubuntu2.6 500
        500 http://br.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages

Running:
smbclient //localhost/pub -U ubuntu%ubuntu -c "pwd;dir;cd dir1;dir;pwd;cd dir11; pwd; dir; cd /; cd dir2; pwd; dir; cd /"

Server valgrind report:
==3887== LEAK SUMMARY:
==3887== definitely lost: 72 bytes in 7 blocks
==3887== indirectly lost: 0 bytes in 0 blocks
==3887== possibly lost: 125,212 bytes in 488 blocks
==3887== still reachable: 117,607 bytes in 901 blocks
==3887== suppressed: 0 bytes in 0 blocks

After update:
==7133== LEAK SUMMARY:
==7133== definitely lost: 24 bytes in 1 blocks
==7133== indirectly lost: 0 bytes in 0 blocks
==7133== possibly lost: 125,212 bytes in 488 blocks
==7133== still reachable: 117,607 bytes in 901 blocks
==7133== suppressed: 0 bytes in 0 blocks

I was hoping the original reported would have tried the updated packages, since he seemed quite affected by this memleak. But in the meantime, this is the verification I can do.

The original report was for Trusty, so the OP wouldn't be able to test if this Bionic package fixes their issue.

Do we intend to also fix this for trusty and xenial? Since I don't see any tasks set or uploads in the unapproved queues.

This bug was fixed in the package samba - 2:4.7.6+dfsg~ubuntu-0ubuntu2.7

---------------
samba (2:4.7.6+dfsg~ubuntu-0ubuntu2.7) bionic; urgency=medium

  * d/p/memleak-fix-13372.patch: Fix memory leak in vfswrap_getwd().
    (LP: #1814532)

 -- Andreas Hasenack <email address hidden> Mon, 04 Feb 2019 17:37:51 -0200

The verification of the Stable Release Update for samba has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

No, we would need a new bug report for trusty.