widelands

Editor crash when setting new 0,0 coordinates

Bug #1815613 reported by Toni Förster
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned
widelands build20-rc1

Bug Description

bzr8980 crashes/freezes the editor when setting a new 0,0 coordinate on the map "Ice Wars".

It seems to be a problem with the map itself. Possibly bug #1815283 is remotely related.

Tags: crash editor

Related branches

lp:~widelands-dev/widelands/bug-1815613-map-origin-segfault
hessenfarmer: Approve (test)
kaputtnik (community): Approve (testing)
Diff: 82 lines (+18/-12)
1 file modified
src/logic/map.cc (+18/-12)
Revision history for this message
Toni Förster (stonerl) wrote :

Bug #1815283 isn't related.

Revision history for this message
kaputtnik (franku) wrote :

This is related to the maps size. Each map size starting from 192x192 let widelands freeze when trying to set 0/0 position.

Memory usage increases here from ~9% to 25% when the freeze happens.

Revision history for this message
kaputtnik (franku) wrote :

Sorry, not memory usage, its processor usage.

kaputtnik (franku)
Changed in widelands:
milestone: none → build20-rc1
tags: added: crash editor
Revision history for this message
GunChleoc (gunchleoc) wrote :

I tried this out in gdb and I am getting a segfault:

Thread 1 "widelands" received signal SIGSEGV, Segmentation fault.
0x00005555565f60af in Widelands::Map::set_origin (this=0x7fffffffa730, new_origin=...) at ../src/logic/map.cc:358
358 fields_[ind] = new_field_order[ind];
(gdb) backtrace
#0 0x00005555565f60af in Widelands::Map::set_origin (this=0x7fffffffa730, new_origin=...) at ../src/logic/map.cc:358
#1 0x0000555556398a8e in EditorSetOriginTool::handle_click_impl (this=0x6170000500e0, center=..., eia=..., map=0x7fffffffa730) at ../src/editor/tools/set_origin_tool.cc:30
#2

Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
Revision history for this message
GunChleoc (gunchleoc) wrote :

Found the bug, a datatype for a loop index is too small

Changed in widelands:
status: New → In Progress
hessenfarmer (stephan-lutz)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.