sg3-utils ftbfs in disco

Bug #1823436 reported by Matthias Klose
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
sg3-utils (Ubuntu)
Fix Released
High
Andreas Hasenack
Cosmic
Triaged
High
Unassigned

Bug Description

https://launchpadlibrarian.net/417924366/buildlog_ubuntu-disco-amd64.sg3-utils_1.42-2ubuntu1_BUILDING.txt.gz

gcc -DHAVE_CONFIG_H -I. -I.. -iquote ../include -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -W -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o sg_map26.o sg_map26.c
sg_map26.c: In function ‘nt_typ_from_filename’:
sg_map26.c:218:14: warning: implicit declaration of function ‘major’ [-Wimplicit-function-declaration]
         ma = major(st.st_rdev);
              ^~~~~
sg_map26.c:219:14: warning: implicit declaration of function ‘minor’; did you mean ‘mknod’? [-Wimplicit-function-declaration]
         mi = minor(st.st_rdev);
              ^~~~~
              mknod
sg_map26.c: In function ‘map_st’:
sg_map26.c:91:21: warning: left shift of negative value [-Wshift-negative-value]
     ((minor) & ~(-1 << ST_MODE_SHIFT)) )
                     ^~
sg_map26.c:811:18: note: in expansion of macro ‘TAPE_NR’
                  TAPE_NR(mi));
                  ^~~~~~~
sg_map26.c: In function ‘map_osst’:
sg_map26.c:91:21: warning: left shift of negative value [-Wshift-negative-value]
     ((minor) & ~(-1 << ST_MODE_SHIFT)) )
                     ^~
sg_map26.c:869:18: note: in expansion of macro ‘TAPE_NR’
                  TAPE_NR(mi));
                  ^~~~~~~
/bin/bash ../libtool --tag=CC --mode=link gcc -Wall -W -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -o sg_map26 sg_map26.o
libtool: link: gcc -Wall -W -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o sg_map26 sg_map26.o
/usr/bin/ld: sg_map26.o: in function `nd_match_scandir_select':
./src/sg_map26.c:359: undefined reference to `major'
/usr/bin/ld: ./src/sg_map26.c:361: undefined reference to `minor'
/usr/bin/ld: sg_map26.o: in function `nt_typ_from_filename':
./src/sg_map26.c:218: undefined reference to `major'
/usr/bin/ld: ./src/sg_map26.c:219: undefined reference to `minor'
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:808: sg_map26] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:401: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:333: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j1 returned exit code 2

Related branches

Matthias Klose (doko)
Changed in sg3-utils (Ubuntu):
importance: Undecided → High
tags: added: ftbfs rls-dd-incoming
Revision history for this message
Matthias Klose (doko) wrote :
tags: added: rls-cc-incoming
Changed in sg3-utils (Ubuntu Cosmic):
status: New → Triaged
importance: Undecided → High
Changed in sg3-utils (Ubuntu):
status: New → Triaged
Changed in sg3-utils (Ubuntu):
assignee: nobody → Andreas Hasenack (ahasenack)
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sg3-utils - 1.42-2ubuntu2

---------------
sg3-utils (1.42-2ubuntu2) eoan; urgency=medium

  * d/p/ftbfs-sysmacro-include.patch: include correct header for the
    major() macro definition. (LP: #1823436)

 -- Andreas Hasenack <email address hidden> Tue, 23 Apr 2019 18:07:53 -0300

Changed in sg3-utils (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I'll leave the cosmic task alone for now. If there is a need for an SRU for another reason, then this bug will be hit, found, and fix is here ready for being grabbed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.