neutron

[L3][QoS] cache does not removed when router is down or deleted

Bug #1826695 reported by LIU Yulong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
LIU Yulong

Bug Description

[L3][QoS] cache does not removed when router is down or deleted

ENV: stable/queens (master has the same issue)

When router is DOWN or deleted, the L3 IP QoS extensions (floating IP and gateway IP) should remove the QoS cache.
Otherwise, if the router is UP again, the floating IP QoS rules may not set to the devices back because the bandwidth value does not change.

See original description
LIU Yulong (dragon889)
Changed in neutron:
assignee: nobody → LIU Yulong (dragon889)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/656105

Changed in neutron:
status: New → In Progress
Slawek Kaplonski (slaweq)
Changed in neutron:
importance: Undecided → Medium
Boden R (boden)
tags: added: l3-ha
tags: added: qos
Revision history for this message
LIU Yulong (dragon889) wrote :

Increase the bug level, because this issue has been submitted for a long time.

Changed in neutron:
importance: Medium → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/656105
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=78629e0d3780af4a8a8cc1b5b0762e0bc8a48f1f
Submitter: Zuul
Branch: master

commit 78629e0d3780af4a8a8cc1b5b0762e0bc8a48f1f
Author: LIU Yulong <email address hidden>
Date: Wed Mar 27 08:40:31 2019 +0800

    Remove L3 IP QoS cache when router is down

    When router admin-state is down or removed, fip-qos and gateway-ip-qos
    extension should delete the router IPs' QoS rate limit cache. Then if
    the router is up again the router floating IPs QoS can be reconfigured.
    This patch achives these:
    1. make sure floating IP or gateway IP QoS cache removed.
    2. floating IP QoS can be re-configured to snat device when router
       doing admin_state down/up.

    Closes-Bug: #1826695
    Change-Id: I24fcecd9686ad17fa50093bb8bccab0d6c711298

Changed in neutron:
status: In Progress → Fix Released
Swaminathan Vasudevan (swaminathan-vasudevan)
tags: added: queens-backport-potential
Bernard Cafarelli (bcafarel)
tags: added: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 15.0.0.0b1

This issue was fixed in the openstack/neutron 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/705202

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/705206

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/705208

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/queens)

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: stable/queens
Review: https://review.opendev.org/705208
Reason: It has too many dependencies to make this backport really possible IMO.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/stein)

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/705202
Reason: I don't think we can backport it as this require https://github.com/openstack/neutron/commit/ab57410ec8e5fae97dec052a5940debd614e4e50 and this one require https://github.com/openstack/neutron/commit/975143fd08f38819859b2251da568af58c8f3a33 which changes requirements.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/rocky)

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/705206

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.