Mahara

config theme not picking up on some colours

Bug #1829091 reported by Liam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Liam
Mahara 19.10.0
19.04
Fix Released
High
Unassigned
Mahara 19.04.1
19.10
Fix Released
High
Liam
Mahara 19.10.0

Bug Description

The configurable is not using colours in some places that should be set for the user. These are found:
-On the my portfolios block when there is more than 11 pages so that the pagination can be viewed. Problem is with the colour of the selected number in the pagination should be the primary/heading colour.
-On a page that has had instructions added (via page settings > advanced). Link should be the link colour of the config theme.
-The colour of the footer links and metadata should be the link colour.
-Share a page with a user and set their role as peer > Add the peer assessment block from general and add some instructions > log in as that user and look at the shared page > click on add assessment. The instructions link should be link colour
- On the same modal as above, the cancel button should be the link colour

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10014

Liam (liam-sharpe)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Steven (stevens-q) wrote :

Commit hash: 793c219154ad708c75cb0292f09ca525062cfbaa
Environment tested: Master
Browser tested: Chrome
Theme used: Default raw | Raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) Two Mahara users exists (no roles) User1 and User2
2) User1 has more than 12 portfolio pages
3) One of the portfolio pages has the following:
      a) Page instructions (found on the page settings)
      b) Peer assessment block with instructions
      c) page is shared with User2 and has the role of peer
4) Institution exists as follows
      a) Theme = configurable

TEST STEPS:
------------------------
1) Log in as User1
2) Browse to the dashboard page
3) Verify that the "My portfolios" block has pagination ✔
4) Verify the page indicator colour for pagination is the same as the primary/heading colour ✔
5) Browse to the portfolio page with the page instructions and peer assessment block as mentioned above
6) Verify that the Page Instructions link has the correct colour associated with the configurable theme ✔
7) Verify that the footer links and metadata is the colour associated with the configurable theme ✔
8) Log out and log in as User2
9) Browse to the portfolio page shared by User1
10) Verify that the Page Instructions link has the correct colour associated with the configurable theme ✔
11) Add a peer assessment
12) Verify that the Modal flyout window displays the peer assessment instructions ✔
13) Verify that the Peer assessment Instructions link has the correct colour associated with the configurable theme ✔
14) Verify that the "Cancel" link has the correct colour associated with the configurable theme ✔

Catalyst Qa Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10014
Committed: https://git.mahara.org/mahara/mahara/commit/793c219154ad708c75cb0292f09ca525062cfbaa
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 793c219154ad708c75cb0292f09ca525062cfbaa
Author: Liam <email address hidden>
Date: Wed May 15 13:32:20 2019 +1200

Bug #1829091: config theme not picking up on some colours

behatnotneeded

Change-Id: Ia2b1e0dee3fcbbd8379fa8f5ae8774619977765a

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10123

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10123
Committed: https://git.mahara.org/mahara/mahara/commit/0676051bc40f99fe7f96ed91b89a575fc6fca8dc
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 0676051bc40f99fe7f96ed91b89a575fc6fca8dc
Author: Liam <email address hidden>
Date: Wed May 15 13:32:20 2019 +1200

Bug #1829091: config theme not picking up on some colours

behatnotneeded

Change-Id: Ia2b1e0dee3fcbbd8379fa8f5ae8774619977765a
(cherry picked from commit 793c219154ad708c75cb0292f09ca525062cfbaa)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.