[MIR] probert as dependency of curtin and subiquity

Bug #1830347 reported by Christian Ehrhardt 
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
probert (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

[Availability]
The package is already available in Ubuntu universe and builds for all
architectures. It creates only one binary which is mostly python and a
bit cpython.

[Rationale]
This is already used in curtin and subiquity and therefore is rather important
already. It will become an official dependency of curtin and therefore needs
to be promoted to main.

[Security]
It has no CVE history upstream or in Ubuntu so far.

[Quality assurance]
- The package does not ask debconf questions
- There are no long-term outstanding bugs which affect the usability of the
  program to a major degree.
- Bug status:
  - Ubuntu has three open bugs waiting for more feedback
  - Debian has no tracker as probert is Ubuntu only
  - Upstream has three open issues (none critical)
- The package is maintainerd well in Ubuntu (native to Ubuntu)
  - upstream as well as the package are owned by the server team
- The package scans HW and in that sense also "deals with exotic HW",
  but it does not require such HW
- The package ships a test suite and runs it at build time
- There are no dep8 tests, but probert is part of curtin and therefore covered
  by the regular server Team QA runs
- it has no d/watch file, but since upstream&package are owned by the same
  team that is not an issue
- there are only a few minor lintian warnings, nothing that needs an
  immediate fix.

[UI standards]

- This is a tool meant for use by other tools (curtin/subiquity). It contains
  no end-user communication (that would need to be translated).
- no End-user application that would need a standard conformant desktop file.

[Dependencies]

- all dependencies (bcache-tools lvm2 mdadm multipath-tools util-linux
  zfsutils-linux python3 python3 python3-jsonschema python3-pyudev
  python3:any libnl-3-200 libnl-genl-3-200 libnl-route-3-200) are already
  in main

[Standards compliance]

Slightly outdated FHS, but generally ok (no major violations)

[Maintenance]

The Server team is already subscribed for to the package for maintenance

[Background]
The description seems correct and sufficient "This package provides a tool for
probing host hardware information and emitting a JSON report." no more
background to add.

Known TODOs:
- it is ok to have no d/watch since upstream has no releases (tarballs) and
  there is no d/watch the server team should add a debian/README.source file
  to the package explaining how a new release would be generated from git
  Filed at https://github.com/CanonicalLtd/probert/issues/67
- going forward it is time for a big bump in dh compat (still 9) and
  standards-version (probably ok as-is)
  Filed at https://github.com/CanonicalLtd/probert/issues/68

Changed in probert (Ubuntu):
assignee: nobody → Christian Ehrhardt  (paelzer)
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Content complete - can't self-review, unassigned me and subscribed the MIR team

description: updated
Changed in probert (Ubuntu):
assignee: Christian Ehrhardt  (paelzer) → nobody
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

done, ready for review

Changed in probert (Ubuntu):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
status: New → In Progress
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Package looks good to me; I've done a review of the source code as well (and I was already somewhat familiar with it for having worked on it some time ago).

MIR Approved.

Changed in probert (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This is in Eoan's excuses for a while now:
  curtin (19.1-0ubuntu1 to 19.1-7-g37a7a0f4-0ubuntu1) in proposed for 27 days
   Unsatisfiable depends:
   probert: amd64

With the MIR now being Ack'ed I think we can promote probert to resolve the component mismatch and let the new curtin migrate.

I subscribed the archive admins to do so.

Changed in probert (Ubuntu):
assignee: Mathieu Trudel-Lapierre (cyphermox) → nobody
Revision history for this message
Steve Langasek (vorlon) wrote :

 probert | 0.0.17 | eoan | source, all

Changed in probert (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Paride Legovini (paride) wrote :

Reopened as probert-network needs to included in main too, as it's a direct dependency of probert.

Changed in probert (Ubuntu):
status: Fix Released → New
summary: - [MIR] probert as dependency of curtin
+ [MIR] probert as dependency of curtin and subiquity
Revision history for this message
Paride Legovini (paride) wrote :

probert-network is now included in main. Fix Released.

Changed in probert (Ubuntu):
status: New → Fix Released
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This is somewhat odd,
probert-network again fell back to universe and then was a component mismatch in excuses.

probert (0.0.20build5 to 0.0.20build6)
Migration status for probert (0.0.20build5 to 0.0.20build6): BLOCKED: Rejected/violates migration policy/introduces a regression
Issues preventing migration:
probert/amd64 in main cannot depend on probert-network in universe
probert/amd64 in main cannot depend on probert-network in universe
Additional info:
63 days old

But at the same time it isn't listed in https://people.canonical.com/~ubuntu-archive/component-mismatches-proposed.html

It is a direct dependency.
Still we see this:

$ rma probert
 probert | 0.0.14.1build2 | bionic/universe | source, amd64, arm64, armhf, i386, ppc64el, s390x
 probert | 0.0.14.1.1 | bionic-updates/universe | source, amd64, arm64, armhf, i386, ppc64el, s390x
 probert | 0.0.18 | focal | source, all
 probert | 0.0.18build1 | focal-updates | source, all
 probert | 0.0.20build5 | jammy | source, all
 probert | 0.0.20build5 | kinetic | source, all
 probert | 0.0.20build5 | lunar | source, all
 probert | 0.0.20build6 | lunar-proposed | source, all

$ rma probert-network
 probert-network | 0.0.18 | focal/universe | amd64, arm64, armhf, ppc64el, riscv64, s390x
 probert-network | 0.0.18build1 | focal-updates/universe | amd64, arm64, armhf, ppc64el, riscv64, s390x
 probert-network | 0.0.20build5 | jammy/universe | amd64, arm64, armhf, ppc64el, riscv64, s390x
 probert-network | 0.0.20build5 | kinetic/universe | amd64, arm64, armhf, ppc64el, riscv64, s390x
 probert-network | 0.0.20build5 | lunar/universe | amd64, arm64, armhf, ppc64el, riscv64, s390x
 probert-network | 0.0.20build6 | lunar-proposed/universe | amd64, arm64, armhf, ppc64el, riscv64, s390x

For now resolved:
$ ./change-override -c main -s lunar-proposed probert-network
Override component to main
probert-network 0.0.20build6 in lunar amd64: universe/admin/optional/100% -> main
probert-network 0.0.20build6 in lunar arm64: universe/admin/optional/100% -> main
probert-network 0.0.20build6 in lunar armhf: universe/admin/optional/100% -> main
probert-network 0.0.20build6 in lunar ppc64el: universe/admin/optional/100% -> main
probert-network 0.0.20build6 in lunar riscv64: universe/admin/optional/100% -> main
probert-network 0.0.20build6 in lunar s390x: universe/admin/optional/100% -> main
Override [y|N]? y
6 publications overridden.

If it happens again this needs a deeper inspection why it falls back.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.