Mahara

Edit dashboard button too low when not using an h1 heading

Bug #1830819 reported by Liam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Liam
Mahara 19.10.0
19.04
Fix Released
High
Unassigned
Mahara 19.04.1
19.10
Fix Released
High
Liam
Mahara 19.10.0

Bug Description

When there is no h1 heading on the dashboard page, the edit dashboard button hovers too low.

To replicate:
1. Go to admin menu > config site > static pages
2. Change top heading from h1 to h2
3. Go back to the dashboard

Expected result: The edit dashboard button is touching the line above it
Actual result: The edit dashboard button is a few pixels below the line

Tags: front-end
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10053

Revision history for this message
Steven (stevens-q) wrote :

Commit hash: 118ef4045cad463cdf7dbfd33583a1be0d98707b
Environment tested: Master
Browser tested: Chrome
Theme used: Raw | Default raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) N/A

TEST STEPS:
------------------------
1) Go to admin menu > config site > static pages
2) Change top heading from h1 to h2
3) Go back to the dashboard
4) Verify the edit dashboard button is touching the line above it

Catalyst QA Approved ✔

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
importance: Undecided → High
Revision history for this message
Steven (stevens-q) wrote :

Commit hash: 118ef4045cad463cdf7dbfd33583a1be0d98707b
Environment tested: Master
Browser tested: Chrome
Theme used: Raw | Default raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) N/A

TEST STEPS:
------------------------
1) Go to admin menu > config site > static pages
2) Change top heading from h1 to the following: and verify the edit dashboard button is touching the line above it on the dashboard page
 a) h2 heading ✔
 b) h3 heading ✔
 c) h4 heading ✔
 d) h5 heading ✔
 e) h6 heading ✔
 f) plain text ✘
 g) insert a small image (200 x 200 px) ✘
 h) insert a small image (400 x 400 px) ✘
 i) insert a small image (800 x 800 px) ✘
 j) insert a small image (1280 x 500 px) ✘

Catalyst QA Failed Testing ✘

Revision history for this message
Steven (stevens-q) wrote :

Also tied a blank line before paragraph text - also fails ✘

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10053
Committed: https://git.mahara.org/mahara/mahara/commit/66bb485993af13f9016491e9f79e336d52b7dba4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 66bb485993af13f9016491e9f79e336d52b7dba4
Author: Liam <email address hidden>
Date: Wed May 29 13:34:14 2019 +1200

Bug #1830819: Edit dashboard button too low when not using an h1 heading

behatnotneeded

Change-Id: If1827b18ac8b398316be89546052847de73edeb6

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10121

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10121
Committed: https://git.mahara.org/mahara/mahara/commit/fe103483608e8cfe45598c4e641e016ce56da9f2
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit fe103483608e8cfe45598c4e641e016ce56da9f2
Author: Liam <email address hidden>
Date: Wed May 29 13:34:14 2019 +1200

Bug #1830819: Edit dashboard button too low when not using an h1 heading

behatnotneeded

Change-Id: If1827b18ac8b398316be89546052847de73edeb6
(cherry picked from commit 66bb485993af13f9016491e9f79e336d52b7dba4)

Revision history for this message
Robert Lyon (robertl-9) wrote :

The failed options can be fixed by putting the item in a paragraph

To get the fails, one needs to edit the HTML code directly, and so can easily be fixed by the user

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.