Serve Angular material icons locally

Bug #1830912 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen 3.3

The Angular application uses Google's material icons, which we currently pull in real time from from Google's servers. However, the icons can also be installed and served locally, allowing us to remove the dependence on Google.

Previous tests of using locally served icons showed that some exhibited odd display behavior, with extra spacing around certain icons.

Plan is to migrate to locally served icons and if the spacing issue cannot be resolved, simply chose different icons where needed. There are only a few icons that exhibit the behavior, so choosing alternates should be simple enough.

Revision history for this message
Bill Erickson (berick) wrote :

Branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1830912-local-mat-icons

When updating from source, run 'npm install' and 'npm update' (to bypass package.lock) in the eg2 directory to pick up changes to package.json.

tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Bill Erickson (berick)
summary: - Server Angular material icons locally
+ Serve Angular material icons locally
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Code rebased to master. Trimmed package.json files down to just the one required change.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

Works for me. I've verified that the icons are no longer fetched from Google servers, and I haven't run across any visual oddities with the locally-served icons.

Signoff branch is user/gmcharlt/lp1830912_signoff.

tags: added: signedoff
Galen Charlton (gmc)
Changed in evergreen:
status: New → Confirmed
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Galen. Pushed to master.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.