Check if we still need the config parameter "developermode"
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
Medium
|
Lisa Seeto | ||
Bug Description
There is the config.php parameter "developermode". It says in /lib/config-
* @global int|bool $cfg->developermode Developer mode
* When set, the following things (among others) will happen:
*
* * 'debug.css' will be included on each page. You can edit this file to add
* debugging CSS at your discretion
* * the unpacked version of MochiKit will be used
*
* These options are a performance hit otherwise, enable when you are
* developing for Mahara
*/
$cfg->developermode = false;
// $cfg->developermode = DEVMODE_DEBUGCSS | DEVMODE_UNPACKEDJS;
---
It would need to be checked what "among others" is. We are not using debug.css and Mochikit has been removed. Before we get rid of the parameter though, it would need to be checked if removing it impacts anything else.
Once the analysis is available, we can make a decision.
| Changed in mahara: | |
| milestone: | 19.10.0 → 20.04.0 |
| Changed in mahara: | |
| milestone: | 20.04.0 → none |
| Changed in mahara: | |
| assignee: | nobody → Lisa Seeto (lisaseeto) |
| Changed in mahara: | |
| status: | Confirmed → In Progress |
| Lisa Seeto (lisaseeto) wrote | #1 |
| Robert Lyon (robertl-9) wrote | #2 |
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #3 |
| Mahara Bot (dev-mahara) wrote A change has been merged | #4 |
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #5 |
| Mahara Bot (dev-mahara) wrote A change has been merged | #6 |
| Changed in mahara: | |
| milestone: | none → 20.10.0 |
| status: | In Progress → Fix Committed |
| Changed in mahara: | |
| status: | Fix Committed → Fix Released |
From what I can tell, enabling $cfg->developermode will only happen when not in production mode and it seems to only have affected whether to include unpacked MochiKit in the site and also whether to include debug.css in the site. Despite the comment including "among others" I couldn't find any other areas affected by this setting.